fix: preserve multi_modal_data in generate_opt_level=0 path#446
Open
sanmuf wants to merge 1 commit into
Open
Conversation
|
fusen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes VLM generation in
generate_scheduler.pyby preservingmulti_modal_datawhen constructinggen_batch.Previously,
request_data.pop(...)only kept tensor fields such asinput_ids,attention_mask, andposition_ids. For multimodal generation,multi_modal_datais stored innon_tensor_batch, so it was dropped before callingactor_cluster.generate(...).As a result, VLM backends such as vLLM/SGLang could receive text-only prompts without image payloads.
For Qwen3-VL in vLLM, this could fail during M-RoPE position initialization with an error like:
IndexError: list index out of range
File ".../vllm/model_executor/models/qwen3_vl.py", line 1521, in get_mrope_input_positions
image_grid_thw[image_index][0]
Changes
multi_modal_datafromrequest_data.non_tensor_batchwhen buildinggen_batch.Why
For VLM models,
multi_modal_datacontains image payloads and prompt token ids required by generation backends. Dropping it causes multimodal sampling to fail or silently degrade to text-only generation.Test
generate_opt_level: 0.multi_modal_datais preserved and passed to the generation backend.