fix(opencode): Use standard resolve function to get proper filePaths for tools#18761
Open
OpeOginni wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): Use standard resolve function to get proper filePaths for tools#18761OpeOginni wants to merge 1 commit intoanomalyco:devfrom
OpeOginni wants to merge 1 commit intoanomalyco:devfrom
Conversation
…perly get file paths for permissions checks
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18762
Type of change
What does this PR do?
When setting permissions for tools in a project that does not have git initialised, it gets the paths of files relative to its worktree, and for non-git projects the worktree is always
/, this breaks permissions as the filePath is not going to be what the Permission Rule expects.So this PR adds a check if the worktree is
/then go ahead to use the Instance directory. It also moves the resolve logic to its own file, so tools can all import from it, this makes the codebase a bit cleaner since all tools use the same logic.How did you verify your code works?
I tested with the case the user had an issue with, for both a non-git project and a git project, it works as it should.
Also added regression tests to the tools affected. The fixes makes them all pass
Screenshots / recordings
Checklist