fix: createOpencode function failure on Windows due to spawn usage#18789
Open
webuilder wants to merge 3 commits intoanomalyco:devfrom
Open
fix: createOpencode function failure on Windows due to spawn usage#18789webuilder wants to merge 3 commits intoanomalyco:devfrom
webuilder wants to merge 3 commits intoanomalyco:devfrom
Conversation
Adds { shell: process.platform === 'win32' } when spawning child processes on Windows,
allowing the system to resolve opencode.cmd from the PATH.
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds { shell: process.platform === 'win32' } when spawning child processes on Windows, allowing the system to resolve opencode.cmd from the PATH.
Issue for this PR
Closes #18792
Type of change
What does this PR do?
When I use opencode sdk on windows. I called
createOpencodefunction, then got a failSo I changed
server.ts, I added ashellflag to the spawn function arguments, setting it to true for Windows and false otherwise.How did you verify your code works?
Verified the fix on Windows 11 and Ubuntu.
Screenshots / recordings
No ui changed.
Checklist
If you do not follow this template your PR will be automatically rejected.