fix: restore cross-spawn behavior for effect child processes#18798
Open
kitlangton wants to merge 12 commits intodevfrom
Open
fix: restore cross-spawn behavior for effect child processes#18798kitlangton wants to merge 12 commits intodevfrom
kitlangton wants to merge 12 commits intodevfrom
Conversation
Bring back the Windows command resolution and shell behavior we lost during the Effect migration by adding a cross-spawn-backed child process spawner. Wire installation and snapshot through it and cover the regression cases with focused process tests.
kitlangton
added a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChildProcessSpawnerlayer backed bycross-spawnso the Effect services get the Windows command resolution and shell behavior we had before the migrationInstallationandSnapshotservices to use that layer instead of the default node spawner.cmdscripts in paths with spaces, and additional file descriptorsTesting
bun typecheckbun run test test/effect/cross-spawn-spawner.test.ts test/installation/installation.test.ts test/snapshot/snapshot.test.tsNotes
Projectout; that wiring stays with the separateeffectify-projectworkpackages/opencodetest run still has one unrelated existing failure inpackages/opencode/test/file/watcher.test.ts