fix: prevent early return in check_for_write_conflict loop#64062
Open
Kundan-CR7 wants to merge 6 commits intoapache:mainfrom
Open
fix: prevent early return in check_for_write_conflict loop#64062Kundan-CR7 wants to merge 6 commits intoapache:mainfrom
Kundan-CR7 wants to merge 6 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Contributor
SameerMesiah97
left a comment
There was a problem hiding this comment.
Looks fine. It seems like this codepath is not currently covered by tests so I think you should add one. A simple case where the first backend returns None and a later one returns a value should be enough.
CI needs to be triggered.
Author
|
@SameerMesiah97 Thanks for the suggestion! Added a test to cover multiple backends where the first returns None and a later one returns a value, ensuring all backends are checked. |
8302091 to
ef202ae
Compare
ef202ae to
3aed320
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a logic issue in
Variable.check_for_write_conflictwhere areturn Nonestatement was placed inside the loop iterating over secrets backends.
Because of this, the function exited after the first iteration, preventing
remaining backends from being checked. This could lead to missed conflict detection
in environments with multiple secrets backends.
The fix moves the
return Nonestatement outside the loop so that all backendsare evaluated before returning.
This change corrects the control flow without introducing any new behavior.
closes: #64060