Skip to content

fix: handle NULL values in /dags/{dag_id}/tasks order_by parameter#64075

Open
Aliipou wants to merge 1 commit intoapache:mainfrom
Aliipou:fix/tasks-endpoint-null-order-by
Open

fix: handle NULL values in /dags/{dag_id}/tasks order_by parameter#64075
Aliipou wants to merge 1 commit intoapache:mainfrom
Aliipou:fix/tasks-endpoint-null-order-by

Conversation

@Aliipou
Copy link

@Aliipou Aliipou commented Mar 22, 2026

Closes #63927

Adds nullslast() handling to the SQLAlchemy order_by clause in the tasks listing endpoint to correctly handle NULL values and prevent incorrect sort ordering.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 22, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 22, 2026
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think changes should be on Pydantic model. Adding a validator is just for this cases and you can even manage time to execute like before after. There are different types of examples in our repo, could you please use that approach and add unit tests?
What I see in the issue is when wrong value passed the sorted won't work. That's why easier to do validations there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/dags/{dag_id}/tasks improper null handling for order_by

2 participants