Split task adoption into two transactions in task adoption#64076
Open
jscheffl wants to merge 1 commit intoapache:mainfrom
Open
Split task adoption into two transactions in task adoption#64076jscheffl wants to merge 1 commit intoapache:mainfrom
jscheffl wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We see longer lasting locks in our production and following the (a bit pending) discussion in Slack (https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1774011646300199) we consider the two steps of
adopt_or_reset_orphaned_tasks()to (1) mark tasks and (2) process tasks might be causing a long lasting lock on thejobtable.First statement is "just" marking all tasks which are missing heartbeats and then the non heartbeat tasks are looped through to handle the failure. As the second step can take a longer time, rows on the
jobtable stay with a lock and other processes might queue up on this - especially if multiple schedulers run in parallel.Therefore proposing to add a commit() as (1) the both parts are logically independent and (2) a potential lock is immediately released.
But it might be conflicting to error handling in PSQL OperationalError handling and retry...
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.