Skip to content

Adjust release guides after Helm 1.20.0 release#64083

Open
jscheffl wants to merge 1 commit intoapache:mainfrom
jscheffl:feature/small-updated-in-release-guide-after-helm-release
Open

Adjust release guides after Helm 1.20.0 release#64083
jscheffl wants to merge 1 commit intoapache:mainfrom
jscheffl:feature/small-updated-in-release-guide-after-helm-release

Conversation

@jscheffl
Copy link
Contributor

Like usual with each release you find some glitches... with this PR some small updates in the docs for Helm chart release for the next release manager.

Note I also stumbled multiple times over the "date" command for voting period which might be working on mac only, not on Linuix... but the one in Helm release works, so replicating this back to providers guide...


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Mar 22, 2026
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither date command works on a mac 🤷 (I always do the vote email prep in a linux container).

```
Thank you everyone. New Helm-Chart is released.

I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).
I invite everyone to help improve the chart for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context switching at release level :D


```shell
curl -s https://airflow.apache.org/index.yaml | yq e '.entries.airflow[0].version' -
curl -s https://airflow.apache.org/index.yaml | yq -e '.entries.airflow[0].version' -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e is for eval, not -e which sets the exit status (not really necessary in this context).

It can also be dropped.

Suggested change
curl -s https://airflow.apache.org/index.yaml | yq -e '.entries.airflow[0].version' -
curl -s https://airflow.apache.org/index.yaml | yq '.entries.airflow[0].version' -


For this to make use the following:

- Draft a new release in https://github.com/apache/airflow/releases/new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Draft a new release in https://github.com/apache/airflow/releases/new
- Create a new release in https://github.com/apache/airflow/releases/new

Let's not use "Draft" since you can actually create a draft release :)


# Create new folder for the release
cd airflow-release/helm-chart
cd asf-dist/release/airflow/helm-chart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the peer of this in the "Remove old releases" section.

Comment on lines +940 to +941
For this to make use the following:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For this to make use the following:

We don't need it.

@eladkal eladkal added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Mar 23, 2026
export IS_SHORTEN_VOTE=$([ $VOTE_DURATION_IN_HOURS -ge 72 ] && echo "false" || echo "true")
export SHORTEN_VOTE_TEXT="This is a shortened ($VOTE_DURATION_IN_HOURS hours vote) as agreed by policy set it https://lists.apache.org/thread/cv194w1fqqykrhswhmm54zy9gnnv6kgm"
export VOTE_END_TIME=$(LANG=en_US.UTF-8 TZ=UTC date -v+"${VOTE_DURATION_IN_HOURS}"H "+%B %d, %Y %H:%M %p")
export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work on MacOS ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't

➜  ~ export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M')
date: illegal option -- -
usage: date [-jnRu] [-I[date|hours|minutes|seconds|ns]] [-f input_fmt]
            [ -z output_zone ] [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
            [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in linux (deb). Maybe we can utilise uname and execute accordingly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with Claude :) Haven't verified through a Mac yet but it metarilised what I mentioned above

OS=$(uname)

if [ "$OS" = "Darwin" ]; then
    # macOS (BSD date)
    export VOTE_END_TIME=$(date -u -v "+${VOTE_DURATION_IN_HOURS}H" -v "+10M" +'%Y-%m-%d %H:%M')
elif [ "$OS" = "Linux" ]; then
    # Linux (GNU date)
    export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M')
else
    echo "Unsupported OS: $OS" >&2
    exit 1
fi

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with comments from Jed

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with comments

```
Thank you everyone. New Helm-Chart is released.

I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context switching at release level :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants