Adjust release guides after Helm 1.20.0 release#64083
Adjust release guides after Helm 1.20.0 release#64083jscheffl wants to merge 1 commit intoapache:mainfrom
Conversation
jedcunningham
left a comment
There was a problem hiding this comment.
Neither date command works on a mac 🤷 (I always do the vote email prep in a linux container).
| ``` | ||
| Thank you everyone. New Helm-Chart is released. | ||
|
|
||
| I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart). |
There was a problem hiding this comment.
| I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart). | |
| I invite everyone to help improve the chart for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart). |
There was a problem hiding this comment.
Context switching at release level :D
|
|
||
| ```shell | ||
| curl -s https://airflow.apache.org/index.yaml | yq e '.entries.airflow[0].version' - | ||
| curl -s https://airflow.apache.org/index.yaml | yq -e '.entries.airflow[0].version' - |
There was a problem hiding this comment.
e is for eval, not -e which sets the exit status (not really necessary in this context).
It can also be dropped.
| curl -s https://airflow.apache.org/index.yaml | yq -e '.entries.airflow[0].version' - | |
| curl -s https://airflow.apache.org/index.yaml | yq '.entries.airflow[0].version' - |
|
|
||
| For this to make use the following: | ||
|
|
||
| - Draft a new release in https://github.com/apache/airflow/releases/new |
There was a problem hiding this comment.
| - Draft a new release in https://github.com/apache/airflow/releases/new | |
| - Create a new release in https://github.com/apache/airflow/releases/new |
Let's not use "Draft" since you can actually create a draft release :)
|
|
||
| # Create new folder for the release | ||
| cd airflow-release/helm-chart | ||
| cd asf-dist/release/airflow/helm-chart |
There was a problem hiding this comment.
You missed the peer of this in the "Remove old releases" section.
| For this to make use the following: | ||
|
|
There was a problem hiding this comment.
| For this to make use the following: |
We don't need it.
| export IS_SHORTEN_VOTE=$([ $VOTE_DURATION_IN_HOURS -ge 72 ] && echo "false" || echo "true") | ||
| export SHORTEN_VOTE_TEXT="This is a shortened ($VOTE_DURATION_IN_HOURS hours vote) as agreed by policy set it https://lists.apache.org/thread/cv194w1fqqykrhswhmm54zy9gnnv6kgm" | ||
| export VOTE_END_TIME=$(LANG=en_US.UTF-8 TZ=UTC date -v+"${VOTE_DURATION_IN_HOURS}"H "+%B %d, %Y %H:%M %p") | ||
| export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M') |
There was a problem hiding this comment.
It doesn't
➜ ~ export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M')
date: illegal option -- -
usage: date [-jnRu] [-I[date|hours|minutes|seconds|ns]] [-f input_fmt]
[ -z output_zone ] [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
[[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
There was a problem hiding this comment.
Works in linux (deb). Maybe we can utilise uname and execute accordingly
There was a problem hiding this comment.
Tried with Claude :) Haven't verified through a Mac yet but it metarilised what I mentioned above
OS=$(uname)
if [ "$OS" = "Darwin" ]; then
# macOS (BSD date)
export VOTE_END_TIME=$(date -u -v "+${VOTE_DURATION_IN_HOURS}H" -v "+10M" +'%Y-%m-%d %H:%M')
elif [ "$OS" = "Linux" ]; then
# Linux (GNU date)
export VOTE_END_TIME=$(date --utc -d "now + $VOTE_DURATION_IN_HOURS hours + 10 minutes" +'%Y-%m-%d %H:%M')
else
echo "Unsupported OS: $OS" >&2
exit 1
fi
potiuk
left a comment
There was a problem hiding this comment.
Approve with comments from Jed
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good with comments
| ``` | ||
| Thank you everyone. New Helm-Chart is released. | ||
|
|
||
| I invite everyone to help improve providers for the next release, a list of open issues can be found [here](https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3Aarea%3Ahelm-chart). |
There was a problem hiding this comment.
Context switching at release level :D
Like usual with each release you find some glitches... with this PR some small updates in the docs for Helm chart release for the next release manager.
Note I also stumbled multiple times over the "date" command for voting period which might be working on mac only, not on Linuix... but the one in Helm release works, so replicating this back to providers guide...
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.