Skip to content

[ErrorProne] remove voidUsed check #37902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −6
Open

[ErrorProne] remove voidUsed check #37902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d83275a
remove void
stankiewicz Mar 21, 2026
3249e2e
outstanding jdbc violation
stankiewicz Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,8 +1581,6 @@ class BeamModulePlugin implements Plugin<Project> {
"StringCaseLocaleUsage",
// DoFn methods are executed reflectively at pipeline runtime
"UnusedMethod",
// Void is a valid element type of DoFn elements
"VoidUsed",
]
disabledChecks.each {
options.errorprone.errorproneArgs.add("-Xep:${it}:OFF")
Expand Down
1 change: 1 addition & 0 deletions ...link/src/test/java/org/apache/beam/runners/flink/streaming/GroupByWithNullValuesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
/** Tests grouping with null values. */
public class GroupByWithNullValuesTest implements Serializable {

@SuppressWarnings("VoidUsed")
@Test
public void testGroupByWithNullValues() {
FlinkPipelineOptions options = FlinkPipelineOptions.defaults();
Expand Down
3 changes: 1 addition & 2 deletions .../java/org/apache/beam/runners/flink/translation/wrappers/streaming/FlinkKeyUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ public void testEncodeDecode() {

@Test
public void testNullKey() {
Void key = null;
VoidCoder coder = VoidCoder.of();

ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(key, coder);
ByteBuffer byteBuffer = FlinkKeyUtils.encodeKey(null, coder);
assertThat(FlinkKeyUtils.decodeKey(byteBuffer, coder), is(nullValue()));
}

Expand Down
4 changes: 3 additions & 1 deletion sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,9 @@ public void testSideInputAnnotationFailedValidationMissing() {
DoFn<Integer, List<Integer>> fn =
new DoFn<Integer, List<Integer>>() {
@ProcessElement
public void processElement(@SideInput(sideInputTag1) String tag1) {}
public void processElement(@SideInput(sideInputTag1) String tag1) {
ProcessContext c;
}
};

thrown.expect(IllegalArgumentException.class);
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2615,7 +2615,7 @@ public DataSource apply(Void input) {
return instances.computeIfAbsent(
config.config,
ignored -> {
DataSource basicSource = config.apply(input);
DataSource basicSource = config.apply(null);
DataSourceConnectionFactory connectionFactory =
new DataSourceConnectionFactory(basicSource);
@SuppressWarnings("nullness") // apache.commons.dbcp2 not annotated
Expand Down
Loading