Reduce number of layers for Beam container images#38440
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the Docker container images for both Java and Go SDKs by reducing the total number of layers. By consolidating build instructions and squashing base images, the changes aim to decrease the frequency of HTTP 429 errors encountered when pulling images from artifact registries, thereby improving deployment reliability. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request optimizes the Dockerfiles for the Go and Java SDKs by squashing layers and consolidating file copy operations. Feedback identifies a critical syntax error in the Java Dockerfile where an inline comment within a multi-line COPY command would break the build. Additionally, it is recommended to use wildcards for optional jars to ensure compatibility across Java versions and to prefer COPY over ADD for local files to align with Docker best practices.
| /opt/apache/beam/jars/ | ||
|
|
||
| # Built jars | ||
| COPY target/open-module-agent.jar target/beam-sdks-java-harness.jar /opt/apache/beam/jars/ |
There was a problem hiding this comment.
The open-module-agent.jar is only present in Java 9+ builds. Using a specific filename in COPY will cause the build to fail if the file is missing (e.g., in Java 8 environments). Using a wildcard (e.g., target/open-module-agent.jar*) makes this file optional and ensures the build remains robust across different Java versions.
COPY target/open-module-agent.jar* target/beam-sdks-java-harness.jar /opt/apache/beam/jars/
| COPY target/${TARGETOS}_${TARGETARCH}/boot target/LICENSE target/NOTICE /opt/apache/beam/ | ||
|
|
||
| # copy third party licenses | ||
| ADD target/third_party_licenses /opt/apache/beam/third_party_licenses/ |
There was a problem hiding this comment.
For local files and directories, COPY is preferred over ADD unless you specifically need the auto-extraction feature of ADD (e.g., for tarballs). Using COPY is more explicit and follows Docker best practices, consistent with other changes in this pull request.
COPY target/third_party_licenses /opt/apache/beam/third_party_licenses/
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
| ADD target/${TARGETOS}_${TARGETARCH}/boot /opt/apache/beam/ |
|
R: @shunping |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Reduced Java container layer from 23->14; reduced Go container layer 17->4.
Mitigate artifact registry GET request http 429 error when frequently pull. The number of request is proportional to the number of container layers.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.