Create volume on a specified storage pool by abh1sar · Pull Request #12966 · apache/cloudstack

abh1sar · 2026-04-06T12:26:26Z

Description

This PR adds support for creating volume on the specified storage pool in the Ready state.
This can be done without attaching the volume to any instance. This can be helpful with vmware2kvm scenarios.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Created volume using the storageid parameter on an NFS storage pool.
Verified that volume was in Ready state with a qcow2 file created with the specified virtual size.

How did you try to break this feature and the system with this change?

codecov · 2026-04-06T12:34:49Z

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (b1bc538) to head (7afb82f).
⚠️ Report is 11 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	24 Missing ⚠️
...stack/api/command/user/volume/CreateVolumeCmd.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12966      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
+ Complexity    15678    15677       -1     
============================================
  Files          5918     5918              
  Lines        531758   531807      +49     
  Branches      65024    65036      +12     
============================================
- Hits          93637    93636       -1     
- Misses       427555   427605      +50     
  Partials      10566    10566

Flag	Coverage Δ
uitests	`3.70% <ø> (-0.01%)`	⬇️
unittests	`18.67% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti

clgtm

abh1sar · 2026-04-07T04:59:45Z

@blueorangutan package

blueorangutan · 2026-04-07T05:02:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-07T06:00:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17378

Copilot

Pull request overview

This PR enhances CloudStack’s createVolume API to support creating a data volume directly on a specified primary storage pool (so it can reach Ready state without attaching to a VM), aimed at workflows like vmware2kvm migrations.

Changes:

Adds a new storageid parameter to createVolume.
Implements a new code path in VolumeApiServiceImpl.createVolume to create the volume on the requested primary storage pool via volService.createVolumeAsync.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java	Adds a `storageid` branch that triggers backend volume creation on a specified primary store.
api/src/main/java/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java	Introduces the `storageid` API parameter and a getter intended to enforce snapshot/storage mutual exclusivity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

api/src/main/java/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

abh1sar · 2026-04-07T08:22:55Z

@blueorangutan package

blueorangutan · 2026-04-07T08:24:05Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-07T09:18:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17384

abh1sar · 2026-04-08T09:39:38Z

@blueorangutan test

blueorangutan · 2026-04-08T09:40:08Z

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti

clgtm

blueorangutan · 2026-04-09T03:58:38Z

[SF] Trillian test result (tid-15822)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62677 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12966-t15822-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	398.05	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	261.80	test_vpc_vpn.py

kiranchavala

@abh1sar

Can you add storageid in the UI also when create volume is called. It will be useful to the admin users

api/src/main/java/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

abh1sar · 2026-04-10T02:22:31Z

@blueorangutan package

abh1sar · 2026-04-10T02:22:40Z

@blueorangutan ui

blueorangutan · 2026-04-10T02:23:08Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2026-04-10T02:44:47Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12966 (QA-JID-905)

sureshanaparti · 2026-04-10T03:50:09Z

@blueorangutan package

blueorangutan · 2026-04-10T03:52:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-10T04:57:07Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17434

kiranchavala

LGTM

Tested manually

Tested the creation of volume on particular storage pool by a rootadmin user on local,nfs, and PowerFlex storage type.

Volumes got created respectivitel storage

Was able to attach the created volume to an instance

kiranchavala · 2026-04-10T09:54:14Z

@blueorangutan test

blueorangutan · 2026-04-10T09:56:04Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-04-10T09:58:15Z

[SF] Trillian Build Failed (tid-15853)

DaanHoogland · 2026-04-10T10:15:09Z

@GaOrtiga , are you fine with the changes now?

Create volume on a specified storage pool

30ee7e2

abh1sar added this to the 4.22.1 milestone Apr 6, 2026

boring-cyborg bot added component:api component:storage labels Apr 6, 2026

sureshanaparti approved these changes Apr 6, 2026

View reviewed changes

sureshanaparti added the status:needs-testing label Apr 6, 2026

abh1sar changed the base branch from main to 4.22 April 6, 2026 12:56

sureshanaparti added this to Apache CloudStack 4.22.1 Apr 7, 2026

github-project-automation bot moved this to Todo in Apache CloudStack 4.22.1 Apr 7, 2026

sureshanaparti moved this from Todo to In Progress in Apache CloudStack 4.22.1 Apr 7, 2026

sureshanaparti requested a review from Copilot April 7, 2026 05:57

Copilot started reviewing on behalf of sureshanaparti April 7, 2026 05:57 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Add checks

3dbfbf7

abh1sar requested a review from sureshanaparti April 8, 2026 09:39

sureshanaparti approved these changes Apr 8, 2026

View reviewed changes

sureshanaparti added the ready-for-testing label Apr 8, 2026

kiranchavala reviewed Apr 9, 2026

View reviewed changes

GaOrtiga reviewed Apr 9, 2026

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java Outdated Show resolved Hide resolved

server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated Show resolved Hide resolved

review comments

b420f90

boring-cyborg bot added the component:UI label Apr 10, 2026

Merge branch '4.22' into create-vol-on-stroage

7afb82f

sureshanaparti added the enhancement label Apr 10, 2026

kiranchavala approved these changes Apr 10, 2026

View reviewed changes

kiranchavala added status:ready-for-merge and removed status:needs-testing ready-for-testing labels Apr 10, 2026

GaOrtiga approved these changes Apr 10, 2026

View reviewed changes

DaanHoogland merged commit df7ff97 into apache:4.22 Apr 10, 2026
24 of 26 checks passed

DaanHoogland deleted the create-vol-on-stroage branch April 10, 2026 12:27

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.1 Apr 10, 2026

Conversation

abh1sar commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Apr 7, 2026

Uh oh!

blueorangutan commented Apr 7, 2026

Uh oh!

blueorangutan commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abh1sar commented Apr 7, 2026

Uh oh!

blueorangutan commented Apr 7, 2026

Uh oh!

blueorangutan commented Apr 7, 2026

Uh oh!

abh1sar commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 9, 2026

Uh oh!

kiranchavala left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abh1sar commented Apr 10, 2026

Uh oh!

abh1sar commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

sureshanaparti commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

blueorangutan commented Apr 10, 2026

Uh oh!

DaanHoogland commented Apr 10, 2026

abh1sar commented Apr 6, 2026 •

edited

Loading

codecov bot commented Apr 6, 2026 •

edited

Loading

kiranchavala left a comment •

edited

Loading