-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Provide session to the udtf call #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! See `main.rs` for how to run it. | ||
|
|
||
| use std::sync::{Arc, LazyLock}; | ||
|
|
||
| use arrow::array::{RecordBatch, StringBuilder}; | ||
| use arrow_schema::{DataType, Field, Schema, SchemaRef}; | ||
| use datafusion::{ | ||
| catalog::{MemTable, TableFunctionArgs, TableFunctionImpl, TableProvider}, | ||
| common::Result, | ||
| execution::SessionState, | ||
| prelude::SessionContext, | ||
| }; | ||
| use datafusion_common::{DataFusionError, plan_err}; | ||
| use tokio::{runtime::Handle, task::block_in_place}; | ||
|
|
||
| const FUNCTION_NAME: &str = "table_list"; | ||
|
|
||
| // The example shows, how to create UDTF that depends on the session state. | ||
| // Defines a `table_list` UDTF that returns a list of tables within the provided session. | ||
|
|
||
| pub async fn table_list_udtf() -> Result<()> { | ||
| let ctx = SessionContext::new(); | ||
| ctx.register_udtf(FUNCTION_NAME, Arc::new(TableListUdtf)); | ||
|
|
||
| // Register different kinds of tables. | ||
| ctx.sql("create view v as select 1") | ||
| .await? | ||
| .collect() | ||
| .await?; | ||
| ctx.sql("create table t(a int)").await?.collect().await?; | ||
|
|
||
| // Print results. | ||
| ctx.sql("select * from table_list()").await?.show().await?; | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| #[derive(Debug, Default)] | ||
| struct TableListUdtf; | ||
|
|
||
| static SCHEMA: LazyLock<SchemaRef> = LazyLock::new(|| { | ||
| SchemaRef::new(Schema::new(vec![ | ||
| Field::new("catalog", DataType::Utf8, false), | ||
| Field::new("schema", DataType::Utf8, false), | ||
| Field::new("table", DataType::Utf8, false), | ||
| Field::new("type", DataType::Utf8, false), | ||
| ])) | ||
| }); | ||
|
|
||
| impl TableFunctionImpl for TableListUdtf { | ||
| fn call_with_args(&self, args: TableFunctionArgs) -> Result<Arc<dyn TableProvider>> { | ||
| if !args.exprs().is_empty() { | ||
| return plan_err!( | ||
| "{}: unexpected number of arguments: {}, expected: 0", | ||
| FUNCTION_NAME, | ||
| args.exprs().len() | ||
| ); | ||
| } | ||
| let state = args | ||
| .session | ||
| .as_any() | ||
| .downcast_ref::<SessionState>() | ||
| .ok_or_else(|| { | ||
| DataFusionError::Internal("failed to downcast state".into()) | ||
| })?; | ||
|
|
||
| let mut catalogs = StringBuilder::new(); | ||
| let mut schemas = StringBuilder::new(); | ||
| let mut tables = StringBuilder::new(); | ||
| let mut types = StringBuilder::new(); | ||
|
|
||
| let catalog_list = state.catalog_list(); | ||
| for catalog_name in catalog_list.catalog_names() { | ||
| let Some(catalog) = catalog_list.catalog(&catalog_name) else { | ||
| continue; | ||
| }; | ||
| for schema_name in catalog.schema_names() { | ||
| let Some(schema) = catalog.schema(&schema_name) else { | ||
| continue; | ||
| }; | ||
| for table_name in schema.table_names() { | ||
| let Some(provider) = block_in_place(|| { | ||
| Handle::current().block_on(schema.table(&table_name)) | ||
| })? | ||
| else { | ||
| continue; | ||
| }; | ||
| catalogs.append_value(catalog_name.clone()); | ||
| schemas.append_value(schema_name.clone()); | ||
| tables.append_value(table_name.clone()); | ||
| types.append_value(provider.table_type().to_string()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| let batch = RecordBatch::try_new( | ||
| Arc::clone(&SCHEMA), | ||
| vec![ | ||
| Arc::new(catalogs.finish()), | ||
| Arc::new(schemas.finish()), | ||
| Arc::new(tables.finish()), | ||
| Arc::new(types.finish()), | ||
| ], | ||
| )?; | ||
|
|
||
| Ok(Arc::new(MemTable::try_new( | ||
| batch.schema(), | ||
| vec![vec![batch]], | ||
| )?)) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ use std::sync::Arc; | |
| use crate::session::Session; | ||
| use arrow::datatypes::SchemaRef; | ||
| use async_trait::async_trait; | ||
| use datafusion_common::Result; | ||
| use datafusion_common::{Constraints, Statistics, not_impl_err}; | ||
| use datafusion_common::{Result, internal_err}; | ||
| use datafusion_expr::Expr; | ||
|
|
||
| use datafusion_expr::dml::InsertOp; | ||
|
|
@@ -507,10 +507,49 @@ pub trait TableProviderFactory: Debug + Sync + Send { | |
| ) -> Result<Arc<dyn TableProvider>>; | ||
| } | ||
|
|
||
| /// Describes arguments provided to the table function call. | ||
| pub struct TableFunctionArgs<'e, 's> { | ||
| /// Call arguments. | ||
| pub exprs: &'e [Expr], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Made private. |
||
| /// Session within which the function is called. | ||
| pub session: &'s dyn Session, | ||
| } | ||
|
|
||
| impl<'e, 's> TableFunctionArgs<'e, 's> { | ||
| /// Make a new [`TableFunctionArgs`]. | ||
| pub fn new(exprs: &'e [Expr], session: &'s dyn Session) -> Self { | ||
| Self { exprs, session } | ||
| } | ||
|
|
||
| /// Get expressions passed as the called function arguments. | ||
| pub fn exprs(&self) -> &'e [Expr] { | ||
| self.exprs | ||
| } | ||
|
|
||
| /// Get a session where the table function is called. | ||
| pub fn session(&self) -> &'s dyn Session { | ||
| self.session | ||
| } | ||
| } | ||
|
|
||
| /// A trait for table function implementations | ||
| pub trait TableFunctionImpl: Debug + Sync + Send + Any { | ||
| /// Create a table provider | ||
| fn call(&self, args: &[Expr]) -> Result<Arc<dyn TableProvider>>; | ||
| #[deprecated( | ||
| since = "53.0.0", | ||
| note = "Implement `TableFunctionImpl::call_with_args` instead" | ||
| )] | ||
| fn call(&self, _exprs: &[Expr]) -> Result<Arc<dyn TableProvider>> { | ||
| internal_err!( | ||
| "TableFunctionImpl::call is not implemented. Implement TableFunctionImpl::call_with_args instead." | ||
| ) | ||
| } | ||
|
|
||
| /// Create a table provider | ||
| fn call_with_args(&self, args: TableFunctionArgs) -> Result<Arc<dyn TableProvider>> { | ||
| #[expect(deprecated)] | ||
| self.call(args.exprs) | ||
| } | ||
| } | ||
|
|
||
| /// A table that uses a function to generate data | ||
|
|
@@ -539,7 +578,20 @@ impl TableFunction { | |
| } | ||
|
|
||
| /// Get the function implementation and generate a table | ||
| #[deprecated( | ||
| since = "53.0.0", | ||
| note = "Use `TableFunction::create_table_provider_with_args` instead" | ||
| )] | ||
| pub fn create_table_provider(&self, args: &[Expr]) -> Result<Arc<dyn TableProvider>> { | ||
| #[expect(deprecated)] | ||
| self.fun.call(args) | ||
| } | ||
|
|
||
| /// Get the function implementation and generate a table | ||
| pub fn create_table_provider_with_args( | ||
| &self, | ||
| args: TableFunctionArgs, | ||
| ) -> Result<Arc<dyn TableProvider>> { | ||
| self.fun.call_with_args(args) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.