Skip to content

chore: Cleanup Cargo profiles#21214

Merged
2010YOUY01 merged 2 commits intoapache:mainfrom
neilconway:neilc/chore-cargo-toml-profiles
Mar 30, 2026
Merged

chore: Cleanup Cargo profiles#21214
2010YOUY01 merged 2 commits intoapache:mainfrom
neilconway:neilc/chore-cargo-toml-profiles

Conversation

@neilconway
Copy link
Copy Markdown
Contributor

@neilconway neilconway commented Mar 28, 2026

Which issue does this PR close?

  • N/A

Rationale for this change

  • Don't explicitly set default values when configuring profiles. For example, release-nonlto explicitly set several build settings (e.g., opt_level, overflow_checks) to their default values, which could be misleading.
  • Fix typos, reorder profile configuration, and other general cleanup

No functional changes.

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link
Copy Markdown
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

I have (let AI) confirmed that the removed configurations are redundant defaults.

@2010YOUY01 2010YOUY01 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into apache:main with commit cc5a3a7 Mar 30, 2026
34 checks passed
@neilconway neilconway deleted the neilc/chore-cargo-toml-profiles branch March 30, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants