Conversation
This reverts commit 4e899ac.
alamb
left a comment
There was a problem hiding this comment.
Let's give it a try! Thank you @blaginin
Do you know what happens if we are running on a spot instance and it is killed/terminated? Does the job auto restart?
Looks to me like spot instances get a 2min grace period: https://aws.amazon.com/blogs/compute/best-practices-to-optimize-your-amazon-ec2-spot-instances-usage/?refid=ea118e8f-a658-4276-ba3a-0086cd46ef98
|
yes, it will be auto restarted 🙂 in fact, that is already been happening to our Rust CI as those also use spot instances (when available) |
|
more on that: https://runs-on.com/configuration/spot-instances/
|
LOL -- my personal experience in the past is that spot instances are pretty stable most of the time, but then every now and again, for totally non transparent reasons, they are killed / moved / unavailable for a while before settling down. |
|
yeah, i saw (rarely) CI spot jobs are killed - then runs-on spawns a retry which is always on-demand not spot |
I had
spot=falsebecause those runs were slow. Now they are quite fast, so we can save up while running them:Before:

After:

Instance family differs between runs (runs-on picks one based on current cost/availability), but the numbers should be illustrative nonetheless.
I also put cpu to 32 since the tests are quite fast