Open
Conversation
github-actions
bot
added
logical-expr
xudong963
reviewed
Mar 30, 2026
Member
There was a problem hiding this comment.
adding a Date64 test would be stronger
xudong963
approved these changes
Mar 30, 2026
Contributor
Author
|
the test case failed, but look like unrelated to my change. |
Contributor
I think it was fixed by @mbutrovich here I merged you PR up from main to get the latest code Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
handle Date32 and Date64 in
get_extreme_valuefunctionAre these changes tested?
yes, add test case
Are there any user-facing changes?