fix: broken main branch due to merge race in #21211#21243
Closed
zhuqi-lucas wants to merge 1 commit intoapache:mainfrom
Closed
fix: broken main branch due to merge race in #21211#21243zhuqi-lucas wants to merge 1 commit intoapache:mainfrom
zhuqi-lucas wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a compilation break caused by using the stale MetricType::DEV enum variant after it was renamed to MetricType::Dev.
Changes:
- Update
MetricType::DEV→MetricType::Devfor the derivedoutput_rows_skewmetric in baseline metrics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
86045b8 to
304b19d
Compare
Contributor
Author
|
CI status: |
Contributor
Author
|
Ok, it's duplicated with #21242 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes compilation error and SLT test failure on main branch.
Rationale for this change
PR #21211 (Add output skewness metric) was based on a version before #21160 renamed
MetricType::DEVtoMetricType::Dev. When both merged, main broke with a compilation error. Additionally, #21211 changed thescan_efficiency_ratiodisplay precision (e.g.22%→22.13%), causing one SLT test to fail.What changes are included in this PR?
MetricType::DEV→MetricType::Devinbaseline.rs(compilation fix)explain_analyze.sltexpected output forscan_efficiency_ratioprecision changeAre these changes safe?
Yes — fixes compilation error and test expectation, no behavior change.