[FLINK-39361][connector-http] Improve README with SQL examples#30
[FLINK-39361][connector-http] Improve README with SQL examples#30featzhang wants to merge 3 commits into
Conversation
davidradl
left a comment
There was a problem hiding this comment.
I have looked at the Kafka connector and - we follow the style of its readme. The Getindata readme was effectively all of the docs. Now the docs are in a folder that will be picked up and knitted into the flink docs when we release. If you can find a nice place in the docs for this - then please change to add there.
Thank you for the guidance! That makes total sense — the README should stay lightweight (following the Kafka connector style), and the richer usage content belongs in docs/ where it gets knitted into the official Flink documentation on release. |
20c61cf to
7698996
Compare
|
Hi @davidradl and @mariyageorge01, You have both previously contributed to the HTTP connector documentation ( This PR adds a Quick Start section to help new users get started quickly with SQL and DataStream API examples. I have addressed all previous review comments, and the latest commits (pushed on 2026-03-31) have:
CI is currently passing ✅ on both Java 11 and Java 17. Could you please take a look and share your feedback? PTAL, thanks! 🙏 |
|
Hi @davidradl, Thank you for your thorough review! 🙏 I've verified that all your review comments from March 17 have been addressed in the subsequent commits (March 31): ✅ All Issues Fixed:
📋 Current State:
Could you please re-review when you have a moment? All your feedback has been incorporated. Thank you! 🙏 |
- Add Quick Start section with SQL examples for HTTP Sink and HTTP Lookup Source to both English and Chinese documentation - Fix HTTP Lookup connector name: use 'http' (not 'rest-lookup') - Add DataStream API example for HTTP Sink (English docs) - Add Quick Start entry to TOC
…to zh docs - Fix SQL sink connector identifier: 'http-sink' -> 'http-async-sink' to match HttpDynamicTableSinkFactory.IDENTIFIER (both English and Chinese docs) - Add DataStream API example for HttpSink to Chinese documentation
…c-sink Fix remaining occurrences of 'http-sink' -> 'http-async-sink' in: - HTTP Sink table creation example - Sink Connector Options table description - Batch submission mode example - Single submission mode example (both English and Chinese documentation)
db7e3df to
ee45277
Compare
What is the purpose of the change
The current README lacks practical usage examples, making it difficult for new users to quickly understand how to configure and use the HTTP connector.
This PR improves the README by adding a Quick Start section that covers the most common connector usage patterns.
Brief change log
CREATE TABLE+INSERT INTO)HttpSinkVerifying this change
This is a documentation-only change. Verification is done by reviewing:
HttpSinkbuilder APIHttpConnectorConfigConstantsandHttpLookupConnectorOptionsDoes this pull request potentially affect one of the following areas?
Documentation
This PR is itself a documentation improvement. All changes are in
README.md.