[lake] Order lake snapshot metadata by commit_timestamp#3324
Open
Kaixuan-Duan wants to merge 1 commit into
Open
[lake] Order lake snapshot metadata by commit_timestamp#3324Kaixuan-Duan wants to merge 1 commit into
Kaixuan-Duan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2625
When tiering commits both a readable snapshot and a tiered snapshot in the same run, the coordinator records two lake snapshot metadata entries. The physical list order does not guarantee chronological ordering, so "latest" may incorrectly point to a stale readable snapshot, breaking the latest-snapshot semantics.
Brief change log
commitTimestampfield toLakeSnapshotMetadatato record server-side commit time for each snapshot entry.LakeTableHelper.registerLakeTableSnapshotV2(), stamp each new entry with a strictly monotonic timestamp viamax(now, prevMax + 1)to guarantee correct ordering even under clock skew.LakeTable.getLatestLakeSnapshotMetadata()to pick the entry with the largestcommitTimestampinstead of blindly returning the last list element.LakeTable.getOrReadLatestReadableTableSnapshot()to traverse entries incommitTimestamp-descending order, so a stale readable entry at the physical tail does not mask a more recent one.LakeTableJsonSerdeto serialize/deserialize the optionalcommit_timestampfield. Legacy znodes without this field fall back toUNKNOWN_COMMIT_TIMESTAMP(0), preserving backward compatibility.Tests
./mvnw -pl fluss-server -am test \
-DfailIfNoTests=false \
-Dtest='LakeTableTest,\
LakeTableJsonSerdeTest,\
LakeTableHelperTest,\
LakeTableSnapshotLegacyJsonSerdeTest,\
LakeTableTieringManagerTest,\
NotifyReplicaLakeTableOffsetTest'
API and Format
lake_snapshotsV2 JSON format adds an optionalcommit_timestampfield per snapshot entry. The field is omitted for legacy entries (backward compatible). No RPC or client API changes.Documentation