HBASE-30153 Upgrade hbase-common to junit5#8219
Merged
Merged
Conversation
Contributor
Author
|
So far the PR is all generated by AI, still need more polishing. Will go out for several days, will come back to this when I'm back. |
Apache9
force-pushed
the
HBASE-30153
branch
2 times, most recently
from
ce3b0ff to
79fccde
Compare
liuxiaocs7
approved these changes
May 17, 2026
Member
liuxiaocs7
left a comment
liuxiaocs7
left a comment
There was a problem hiding this comment.
Overall LGTM, just a few minor nits, thanks @Apache9
Comment on lines
-76
to
+71
| @Test(timeout = 10000) | ||
| @Test |
Member
There was a problem hiding this comment.
We remove 10s timeout here, need to add @Timeout(value = 10, unit = TimeUnit.SECONDS)?
Contributor
Author
There was a problem hiding this comment.
This is not necessary, we only want to have a timeout on class level, setting by the test Tag.
| @TestTemplate | ||
| public void testLoadKeyStoreWithWrongFilePath() { | ||
| assertThrows(IOException.class, () -> { | ||
| String path = x509TestContext.getKeyStoreFile(KeyStoreFileType.PKCS12).getAbsolutePath(); |
Member
There was a problem hiding this comment.
ditto, and the remaining tests in this class
| PositionedByteRange buf = new SimplePositionedMutableByteRange(4); | ||
| s.encode(buf, new Object[1]); | ||
| assertThrows(NullPointerException.class, () -> { | ||
| Struct s = new StructBuilder().add(new RawStringTerminated("|")) // not nullable |
Apache9
added a commit
that referenced
this pull request
May 18, 2026
Signed-off-by: Xiao Liu <liuxiaocs@apache.org> (cherry picked from commit 5c74212)
Apache9
added a commit
that referenced
this pull request
May 19, 2026
(cherry picked from commit 5c74212) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Apache9
added a commit
that referenced
this pull request
May 19, 2026
(cherry picked from commit 5c74212) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
Apache9
added a commit
that referenced
this pull request
May 19, 2026
(cherry picked from commit 5c74212) Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.