Add FROM-first query syntax support#17410
Open
Abdelrahman-358 wants to merge 2 commits intoapache:masterfrom
Open
Add FROM-first query syntax support#17410Abdelrahman-358 wants to merge 2 commits intoapache:masterfrom
Abdelrahman-358 wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for the feature proposed in #17336 by introducing FROM-first query syntax.
Usage Examples
-- Current syntax
SELECT temperature, humidity FROM sensors WHERE time >= 10;
-- FROM-first syntax
FROM sensors SELECT temperature, humidity WHERE time >= 10;
-- Quick exploration (omitting SELECT implies SELECT *)
FROM sensors LIMIT 10;
Implementation Approach
Grammar Update
Add
fromFirstQuerySpecificationrule toRelationalSql.g4.AST Builder
Add
visitFromFirstQuerySpecification()inAstBuilder.java, reusing the existingvisitQuerySpecification()logic, with handling for the omitted SELECT clause (interpreted asSELECT *).Testing
Add unit and integration tests to cover the new syntax scenarios.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR