espressif/rmt: replace rmtchar with arch-specific lirc adapter#18654
Open
PiyushPatle26 wants to merge 1 commit intoapache:masterfrom
Open
espressif/rmt: replace rmtchar with arch-specific lirc adapter#18654PiyushPatle26 wants to merge 1 commit intoapache:masterfrom
PiyushPatle26 wants to merge 1 commit intoapache:masterfrom
Conversation
Replace the ESP-specific rmtchar upper-half with arch-local esp_lirc adapters for Xtensa and RISC-V. This moves the RMT upper-half out of drivers/rmt, registers LIRC devices from the ESP board bring-up paths, and removes the old common rmtchar driver and headers. Also update the ESP Kconfig and build wiring to build esp_lirc when ESP_RMT and DRIVERS_RC are enabled. Fixes discovered during hardware validation: - register TX as /dev/lirc1 so RX and TX do not collide - parse the RX worker thread argument from the correct argv slot - keep RX devices from advertising TX capability Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
PiyushPatle26
requested review from
acassis,
fdcavalcanti,
jerpelea,
pkarashchenko,
tmedicci and
xiaoxiang781216
as code owners
github-actions
bot
added
Arch: risc-v
| @@ -2,46 +2,3 @@ | |||
| # For a description of the syntax of this configuration file, | |||
| # see the file kconfig-language.txt in the NuttX tools repository. | |||
Contributor
There was a problem hiding this comment.
should we remove ALL files under drivers/rmt
| @@ -1,2 +1,2 @@ | |||
| ############################################################################ | |||
| # drivers/rmt/Make.defs | |||
Contributor
There was a problem hiding this comment.
remove drivers/rmt/Make.defs
| @@ -1 +1 @@ | |||
| # ############################################################################## | |||
Contributor
There was a problem hiding this comment.
remove drivers/rmt/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the ESP-specific rmtchar upper-half with arch-local esp_lirc adapters for Xtensa and RISC-V.
This moves the RMT upper-half out of drivers/rmt, registers LIRC
devices from the ESP board bring-up paths, and removes the old common
rmtchar driver and headers.
Also update the ESP Kconfig and build wiring to build esp_lirc when
ESP_RMT and DRIVERS_RC are enabled.
Tested on: ESP32-DEVKITC (Chip v1.0)
booted with CONFIG_ESP32_IGNORE_CHIP_REVISION_CHECK=y for local validation only
/dev/lirc0/dev/lirc1/dev/leds0Fixes discovered during hardware validation:
Logs:
Irtest seems struck so need guidance on what must be changed to validate completely