Skip to content

HDDS-15033. Link SCM allocate-block calls to client trace.#10081

Open
sravani-revuri wants to merge 2 commits intoapache:masterfrom
sravani-revuri:HDDS-15033
Open

HDDS-15033. Link SCM allocate-block calls to client trace.#10081
sravani-revuri wants to merge 2 commits intoapache:masterfrom
sravani-revuri:HDDS-15033

Conversation

@sravani-revuri
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Link block allocation calls to SCM by providing proper context. This ensures SCM calls are recorded as child spans under the original client-to-OM trace hierarchy.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15033

How was this patch tested?

Manual Testing through Jaeger UI.

put key command :

ozone sh key put vol1/bucket1/key1 /etc/hostname
image

freon ockg command :

ozone freon ockg -v vol1 -b bucket1 -t 1 -n 5 -s 1KB
image

freon rk command :

ozone freon rk --numOfVolumes=1 --numOfBuckets=1 --numOfKeys=1
image

Copy link
Copy Markdown
Contributor

@sreejasahithi sreejasahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sravani-revuri
overall LGTM, just a minor nit

Co-authored-by: sreejasahithi <115860222+sreejasahithi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Gargi-jais11 Gargi-jais11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sravani-revuri for the patch. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants