HDDS-14822. Add a configuration for excluding Datanodes from pipelines#9914
Draft
siddhantsangwan wants to merge 5 commits intoapache:masterfrom
Draft
HDDS-14822. Add a configuration for excluding Datanodes from pipelines#9914siddhantsangwan wants to merge 5 commits intoapache:masterfrom
siddhantsangwan wants to merge 5 commits intoapache:masterfrom
Conversation
sumitagrawl
reviewed
Mar 17, 2026
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@siddhantsangwan Thanks for working over this, given a comment
| TimeUnit.MILLISECONDS); | ||
| this.freezePipelineCreation = new AtomicBoolean(); | ||
| this.pipelineExcludedNodes = conf.getObject(ScmConfig.class).getPipelineExcludedNodes(); | ||
| this.configuredExcludedDatanodeDetails = resolvePipelineExcludedNodesToDatanodeDetails(); |
Contributor
There was a problem hiding this comment.
When any new dn is added, configuredExcludedDatanodeDetails can change to include that dn earlier not reported. So this needs dynamically refreshed.
Contributor
There was a problem hiding this comment.
To simplify, this needs to be part of NodeManager as holder, and to be retrieved on need basis, so that dyanmically update of new dn added / removed can be handled.
adoroszlai
reviewed
Mar 17, 2026
| /** | ||
| * Parsed and normalized snapshot of {@code hdds.scm.pipeline.exclude.datanodes}. | ||
| */ | ||
| public static final class PipelineExcludedNodes { |
Contributor
There was a problem hiding this comment.
I suggest moving PipelineExcludedNodes class to top-level to avoid bloating ScmConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds an SCM configuration for excluding Datanodes from pipeline creation and selection.
ExcludeListprovided by the ozone client.Limitations:
To handle this, we should either have some thread (or other mechanism) for closing useless open pipelines. Or not count excluded but open pipelines when counting if the limit has reached. This can be done in a future PR.
Workaround: The manual workaround is to increase the configured limits.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14822
How was this patch tested?
Added unit tests.
Successful CI run in my fork - https://github.com/siddhantsangwan/ozone/actions/runs/23043011479.