HDDS-14870. Allow balancing of over replicated and quasi closed containers

[sarvekshayr]

What changes were proposed in this pull request?

Allow container balancer to include containers if

• Container State is CLOSED and ContainerHealthState is OVER_REPLICATED but has minimum CLOSED replicas based on replication config along with additional QUASI_CLOSED replicas
• Container State is QUASI_CLOSED and has all replicas in QUASI_CLOSED state.

This is allowed only if the new config hdds.container.balancer.include.non.standard.containers is set to true.

What is the link to the Apache JIRA

HDDS-14870

How was this patch tested?

Added tests in TestContainerBalancerSelectionCriteria and TestMoveManager.

[sreejasahithi]

Thanks @sarvekshayr

I wanted to double check my understanding:
When includeNonStandardContainers is true, ContainerBalancerSelectionCriteria correctly allows:

• Case A: CLOSED + OVER_REPLICATED containers (with min CLOSED replicas + QUASI_CLOSED replicas)
• Case B: QUASI_CLOSED containers with all QUASI_CLOSED replicas

However, MoveManager.move() still enforces:

• Health must be HEALTHY – so OVER_REPLICATED is rejected with REPLICATION_NOT_HEALTHY_BEFORE_MOVE
• Container state must be CLOSED – so QUASI_CLOSED is rejected with REPLICATION_FAIL_CONTAINER_NOT_CLOSED

Since MoveManager doesn’t consider the config, it never sees includeNonStandardContainers. That would mean these containers get selected but fail when we actually try to move them.
Did you intend to update MoveManager as well to honor this config, or is there another path i am missing? I want to make sure i am not misreading the flow.