Skip to content

Commit 0de96b1

Browse files
authored
Update the guidance for pinging interested parties on PRs (#680)
1 parent dc5671d commit 0de96b1

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

contributing.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,7 @@ will trigger workflows "On pull request*" (on Spark repo) that will look/watch f
411411
but needs to be pushed to GitHub to facilitate review, then add `[WIP]` after the component.
412412
1. Consider identifying committers or other contributors who have worked on the code being
413413
changed. Find the file(s) in GitHub and click "Blame" to see a line-by-line annotation of
414-
who changed the code last. You can add `@username` in the PR description to ping them
415-
immediately.
414+
who changed the code last. You can add `@username` in a comment on the PR to ping them.
416415
1. Please state that the contribution is your original work and that you license the work
417416
to the project under the project's open source license.
418417
1. The related JIRA, if any, will be marked as "In Progress" and your pull request will

site/contributing.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -610,8 +610,7 @@ <h3>Pull request</h3>
610610
but needs to be pushed to GitHub to facilitate review, then add <code class="language-plaintext highlighter-rouge">[WIP]</code> after the component.</li>
611611
<li>Consider identifying committers or other contributors who have worked on the code being
612612
changed. Find the file(s) in GitHub and click &#8220;Blame&#8221; to see a line-by-line annotation of
613-
who changed the code last. You can add <code class="language-plaintext highlighter-rouge">@username</code> in the PR description to ping them
614-
immediately.</li>
613+
who changed the code last. You can add <code class="language-plaintext highlighter-rouge">@username</code> in a comment on the PR to ping them.</li>
615614
<li>Please state that the contribution is your original work and that you license the work
616615
to the project under the project&#8217;s open source license.</li>
617616
</ol>

0 commit comments

Comments
 (0)