[SPARK-56252][HISTORY] History server disk store lease should remove temp path delete hook after commit and rollback to avoid memory leak#54947
Open
LennonChin wants to merge 2 commits intoapache:masterfrom
Open
Conversation
…fter commit and rollback to avoid memory leak
LennonChin
changed the title
Author
pan3793
reviewed
Mar 27, 2026
| val newSize = sizeOf(tmpPath) | ||
| makeRoom(newSize) | ||
| tmpPath.renameTo(dst) | ||
| ShutdownHookManager.removeShutdownDeleteDir(tmpPath) |
Member
There was a problem hiding this comment.
You may need to check the return value of tmpPath.renameTo(dst) - File.renameTo returns true iff the renaming succeeded; false otherwise.
Member
|
@LennonChin, this makes sense, please fill a Jira ticket and complete the PR description. |
LennonChin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the History Server DiskManager, when acquiring a lease, a temporary directory is created on the disk, and a JVM shutdown hook is registered used to remove this temporary directory. When the lease is committed or rolled back, the temporary directory is either renamed to the target directory or deleted, but the registered JVM shutdown hook remains in the ShutdownHookManager, causing a memory leak. Additionally, a large number of residual hooks will execute when the History Server restarts, severely slowing down the restart process.
Why are the changes needed?
We should remove residual hooks when lease committed or rolled back.
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?