fix(symfony): security regression when ResourceAccessChecker is decorated (#7896)#7897
Open
giosh94mhz wants to merge 1 commit intoapi-platform:4.3from
Open
fix(symfony): security regression when ResourceAccessChecker is decorated (#7896)#7897giosh94mhz wants to merge 1 commit intoapi-platform:4.3from
giosh94mhz wants to merge 1 commit intoapi-platform:4.3from
Conversation
…ated (api-platform#7896) Commit 359a128 introduced a regression when ResourceAccessChecker is decorated, and security/securityPostDenormalize are using object in is_granted expression. The issue arise since AccessCheckerProvider violates the Liskov substitution principle by assuming that if the (previously unknown) interface ObjectVariableCheckerInterface is not defined, then the pre_read optimization can be used without an object instance.
817d0e4 to
0e709bb
Compare
soyuka
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 359a128 introduced a regression when ResourceAccessChecker is decorated, and
security/securityPostDenormalizeare usingobjectinis_grantedexpression.The issue arise since
AccessCheckerProviderviolates the Liskov substitution principle by assuming that if the (previously unknown) interfaceObjectVariableCheckerInterfaceis not defined, then thepre_readoptimization can be used without an object instance.NOTE: this is a security evaluation regression that actually will blocks more then required, so not a security issue on the project itself.
The solution (in addition to this PR)
To preserve the implementation I had to implement
ObjectVariableCheckerInterfacein my codebased (which is not optimal, maybe should be documented or refactored). This is a workaround also for versions 4.3.0 => 4.3.3.