fix: fix type checker errors for pyright#1203
Merged
KazuCocoa merged 10 commits intoappium:masterfrom Mar 5, 2026
Merged
Conversation
In `py.typed` modules, imported symbols considered private[^1], which is not importable by users. To become public interface, explicit `__all__` symbol is required. [^1]: https://typing.python.org/en/latest/spec/distributing.html#library-interface-public-and-private-symbols
Added deprecation warnings for unimplemented methods in CanExecuteScripts protocol.
|
|
||
| from typing import Any, List, Optional, Protocol | ||
| from typing import Any, List, Optional, Protocol, TYPE_CHECKING | ||
| from warings import deprecated |
| # TODO: remove `if not TYPE_CHECKING` guard after properly implement them | ||
| # The use of these methods will produce DeprecationWarnings at runtime | ||
| if not TYPE_CHECKING: | ||
| @deprecated("pin_script is not yet implemented") |
Contributor
There was a problem hiding this comment.
I would rather say is deprecated for removal
Contributor
Author
There was a problem hiding this comment.
I assumed those methods would be implemented later. If there are no plans to do so, I will make the changes as you suggested.
Contributor
There was a problem hiding this comment.
I am not sure it makes sense to implement them in mobile context, but it still makes sense to confirm that with other maintainers
KazuCocoa
reviewed
Mar 3, 2026
appium/webdriver/__init__.py
Outdated
| Appium Python Client: WebDriver module | ||
| """ | ||
|
|
||
| __all__ = ["Remote", "WebElement"] |
Member
There was a problem hiding this comment.
This change looks reasonable to me. This fixes mypy --strict also.
KazuCocoa
reviewed
Mar 4, 2026
Member
KazuCocoa
left a comment
KazuCocoa
left a comment
There was a problem hiding this comment.
Lg to me. Waiting for the CI result
KazuCocoa
changed the title
KazuCocoa
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a more detailed explanation, please refer to this link.