Fix cross-repo inbound deeplinks and iOS HTTPS send-to-Mac#383
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix cross-repo inbound deeplinks and iOS HTTPS send-to-Mac#383cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Block createLaneFromPrBranch when the requested GitHub repo does not match the active project's origin remote, preventing lane imports into the wrong checkout when a deeplink targets another repository. Accept https://ade.app/open URLs in sync deeplinks.open (iOS Send to Mac) by validating with parseDeeplink instead of requiring ade:// only. Clear local runtime client state when an owned child process exits. Co-authored-by: Arul Sharma <arul28@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Wrong-project lane creation from inbound branch/PR deeplinks
When multiple projects are open, OS-routed deeplinks (
ade:/// second-instance) dispatch to the focused window.InboundDeeplinkModalcan create a lane from a PR in repo A while the active project’soriginpoints at repo B. If the wrong checkout has a colliding branch name onorigin, preflight could pass and import the wrong branch into the wrong workspace.iOS “Send to Mac” broken for HTTPS open links
iOS forwards both
ade://andhttps://ade.app/open?...URLs, butdeeplinks.openrejected non-ade:protocols. Users saw “Sent” on iOS while desktop never navigated.Local runtime stale connection after child exit
When an app-owned
ade servechild exited without a socket disconnect callback,activeClientandprojectsByRootwere left populated whileconnectionwas cleared, so status could read “connected” while RPC failed.Root cause
createLaneFromPrBranchpreflight fetched PR metadata for the deeplink repo but ran git checks against the activeprojectRootwithout verifying the project’s GitHub remote matched.syncRemoteCommandServiceused a rawURL.protocol === "ade:"gate instead of sharedparseDeeplink(which already accepts HTTPS open URLs).localRuntimeConnectionPoolchildexithandler only nulledconnection.Fix and validation
project_repo_mismatchwhengetRepoOrThrow()disagrees with explicit deeplink repo args.deeplinks.openURLs viaparseDeeplink; pass the original URL through to desktop dispatch.activeClientandprojectsByRooton owned-child exit/error.prService.createLaneFromPrBranchcross-repo block case; existing pool tests pass.npm run typecheckinapps/desktopandapps/ade-cli.