Bump @typescript-eslint/parser from 6.21.0 to 8.60.0 in /apps/desktop#424
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
PR author is in the excluded authors list. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review
Scope: 2 file(s), +209 / −17
Verdict: Needs changes
Dependabot bumps only @typescript-eslint/parser in apps/desktop from 6.21.0 to 8.60.0 while @typescript-eslint/eslint-plugin stays on 6.21.0. That breaks the monorepo’s peer contract and leaves two major versions of typescript-eslint loaded together.
🐛 Functionality
[High] Parser and eslint-plugin major versions must match
File: apps/desktop/package.json:L136-L137
Issue: @typescript-eslint/eslint-plugin@6.21.0 requires @typescript-eslint/parser@^6.0.0, but this PR installs parser 8.60.0. npm ls reports the parser as invalid, and nested lockfile entries install parallel v6 (plugin) and v8 (parser) @typescript-eslint/* trees. typescript-eslint expects all @typescript-eslint/* packages on the same major version; mixing v6 rules with a v8 parser is unsupported and can change type-aware lint behavior unpredictably.
Repro: After npm ci in apps/desktop, run npm ls @typescript-eslint/parser @typescript-eslint/eslint-plugin — exit code 1 with invalid: "^6.0.0 || ^6.0.0-alpha" from node_modules/@typescript-eslint/eslint-plugin.
Fix: Bump both devDependencies together, e.g. set @typescript-eslint/eslint-plugin and @typescript-eslint/parser to ^8.60.0, regenerate package-lock.json, and re-run npm run lint. Alternatively close this PR and keep both packages on the 6.x line until you are ready for a coordinated major upgrade.
Notes
npm ciandnpm run lintcurrently succeed locally despite the peer mismatch; the blocker is the invalid dependency graph and unsupported version pairing, not an immediate lint crash.@typescript-eslint/parser@8.60.0is a dev-only tool (not shipped in the desktop app). It is actively maintained by the typescript-eslint project; no new runtime trust boundary is introduced.eslint.config.mjsloads both packages as plugins/parser — any follow-up upgrade should treat them as a single unit.- GitHub shows mergeable state as unstable; confirm required CI checks after fixing the version pair.
Sent by Cursor Automation: BUGBOT in Versic
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.21.0 to 8.60.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-version: 8.60.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/apps/desktop/typescript-eslint/parser-8.60.0
branch
from
eaa1bbb to
41096c0
Compare
Bumps @typescript-eslint/parser from 6.21.0 to 8.60.0.
Release notes
Sourced from @typescript-eslint/parser's releases.
... (truncated)
Changelog
Sourced from @typescript-eslint/parser's changelog.
... (truncated)
Commits
f891c29chore(release): publish 8.60.0ca6ca14chore(release): publish 8.59.448e13c0chore(release): publish 8.59.344f9625chore(deps): update vitest monorepo to v4.1.5 (#12307)2ec35f1chore(release): publish 8.59.25245793chore(release): publish 8.59.1ea9ae4fchore(release): publish 8.59.090c2803chore(release): publish 8.58.2be6b49afix: remove tsbuildinfo cache file from published packages (#12187)5311ed3chore(release): publish 8.58.1Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@typescript-eslint/parsersince your current version.