Bump @typescript-eslint/eslint-plugin from 6.21.0 to 8.60.0 in /apps/desktop#425
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
PR author is in the excluded authors list. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review
Scope: 2 file(s), +442 / −61
Verdict: Needs changes
Dependabot bumps @typescript-eslint/eslint-plugin from 6.21.0 to 8.60.0 in apps/desktop but leaves @typescript-eslint/parser on 6.21.0. That violates the v8 plugin’s required peer range and leaves two major versions of the typescript-eslint stack installed side by side.
🐛 Functionality
[High] ESLint plugin and parser major versions are out of sync
File: apps/desktop/package.json:L136-L137
Issue: The plugin is bumped to ^8.60.0 while the parser stays at ^6.21.0. @typescript-eslint/eslint-plugin@8.60.0 declares a peer dependency on @typescript-eslint/parser@^8.60.0 (see apps/desktop/package-lock.json:L6754-L6757). After install, npm ls reports the parser as invalid for the plugin (invalid: "^8.60.0" from node_modules/@typescript-eslint/eslint-plugin). The lockfile nests a full v8 toolchain under the plugin while the top-level parser remains v6, so type-aware rules can run against mismatched AST/type-utils versions.
Repro: Check out this branch, run cd apps/desktop && npm ci && npm ls @typescript-eslint/eslint-plugin @typescript-eslint/parser — npm exits with ELSPROBLEMS and marks @typescript-eslint/parser@6.21.0 invalid.
Fix: Bump @typescript-eslint/parser to ^8.60.0 in the same change (or merge with the open Dependabot parser PR on this repo) and regenerate package-lock.json so plugin and parser resolve to a single v8 line.
Notes
npm ciandnpm run lintboth succeed on this branch today (193 warnings, 0 errors), so CI may not fail immediately — but the install is explicitly unsupported by upstream and is brittle if peer checks tighten or type-aware rules change behavior across majors.- There is a separate Dependabot branch/PR for
@typescript-eslint/parser@8.60.0; treating plugin and parser bumps as one unit avoids repeated lockfile churn. - This is a devDependency-only change; it does not affect the shipped Electron app bundle or runtime security surface.
- I did not load feature docs — the diff touches only
package.json/package-lock.json.
Sent by Cursor Automation: BUGBOT in Versic
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.21.0 to 8.60.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.60.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/apps/desktop/typescript-eslint/eslint-plugin-8.60.0
branch
from
518d75e to
6ff4c89
Compare
Bumps @typescript-eslint/eslint-plugin from 6.21.0 to 8.60.0.
Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.
... (truncated)
Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.
... (truncated)
Commits
f891c29chore(release): publish 8.60.0ca6ca14chore(release): publish 8.59.44302433fix(eslint-plugin): [no-floating-promises] stack overflow when using recursiv...10b79f1chore(deps): update dependency eslint to v10.4.0 (#12339)2a6765dchore: clenaupgetAwaitedTypefromtypescript.d.ts(#12302)48e13c0chore(release): publish 8.59.3e26dc80docs: update stale links to latest (#12313)44f9625chore(deps): update vitest monorepo to v4.1.5 (#12307)2ec35f1chore(release): publish 8.59.2ec3ef25test: make no-useless-empty-export tests fully static (#12260)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@typescript-eslint/eslint-pluginsince your current version.