-
Notifications
You must be signed in to change notification settings - Fork 420
[WIP] General tweaks to configuration and such to bring codebase up to date #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 8 commits
793636b
a40df57
77f7e24
650f23e
b0147a6
70c1fb1
a73a19c
ccfafb9
a81b641
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,5 @@ | |
| pkg | ||
| Gemfile.lock | ||
| coverage | ||
| /.idea | ||
| /gemfiles/*.gemfile.lock | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| os: linux | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. travis no longer offer supports for opensource project. |
||
| dist: xenial | ||
| language: ruby | ||
| cache: bundler | ||
| script: "bundle exec rake test" | ||
| rvm: | ||
| - 2.0 | ||
| - 2.1 | ||
| - 2.2 | ||
| - 2.3 | ||
| - 2.4 | ||
| - 2.5 | ||
| - 2.6 | ||
| - 2.7 | ||
| - 3.0 | ||
| - head | ||
| - rbx | ||
| gemfile: | ||
| - gemfiles/rails_3.0.gemfile | ||
| - gemfiles/rails_3.1.gemfile | ||
| - gemfiles/rails_3.2.gemfile | ||
| - gemfiles/rails_4.0.gemfile | ||
| - gemfiles/rails_4.1.gemfile | ||
| - gemfiles/rails_4.2.gemfile | ||
| - gemfiles/rails_5.0.gemfile | ||
| - gemfiles/rails_5.1.gemfile | ||
| - gemfiles/rails_5.2.gemfile | ||
| - gemfiles/rails_6.0.gemfile | ||
| - gemfiles/rails_6.1.gemfile | ||
| - gemfiles/rails_7_edge.gemfile | ||
| - gemfiles/datamapper.gemfile | ||
| - gemfiles/sequel.gemfile | ||
| jobs: | ||
| allow_failures: | ||
| - rvm: head | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| - rvm: rbx | ||
| fast_finish: false | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,158 @@ | ||
| sudo: false | ||
| --- | ||
| os: linux | ||
| dist: xenial | ||
| language: ruby | ||
| cache: bundler | ||
| script: bundle exec rake test | ||
| rvm: | ||
| - 2.0 | ||
| - 2.1 | ||
| - 2.2.2 | ||
| - 2.3.0 | ||
| - 2.4.0 | ||
| - 2.5.0 | ||
| - rbx | ||
| env: | ||
| - ACTIVERECORD=3.0.0 | ||
| - ACTIVERECORD=3.1.0 | ||
| - ACTIVERECORD=3.2.0 | ||
| - ACTIVERECORD=4.0.0 | ||
| - ACTIVERECORD=4.1.0 | ||
| - ACTIVERECORD=4.2.0 | ||
| - ACTIVERECORD=5.0.0 | ||
| - ACTIVERECORD=5.1.1 | ||
| matrix: | ||
| exclude: | ||
| - rvm: 2.0 | ||
| env: ACTIVERECORD=5.0.0 | ||
| - rvm: 2.0 | ||
| env: ACTIVERECORD=5.1.1 | ||
| - rvm: 2.1 | ||
| env: ACTIVERECORD=5.0.0 | ||
| - rvm: 2.1 | ||
| env: ACTIVERECORD=5.1.1 | ||
| - rvm: 2.4.0 | ||
| env: ACTIVERECORD=3.0.0 | ||
| - rvm: 2.4.0 | ||
| env: ACTIVERECORD=3.1.0 | ||
| - rvm: 2.4.0 | ||
| env: ACTIVERECORD=3.2.0 | ||
| - rvm: 2.4.0 | ||
| env: ACTIVERECORD=4.0.0 | ||
| - rvm: 2.4.0 | ||
| env: ACTIVERECORD=4.1.0 | ||
| - rvm: 2.5.0 | ||
| env: ACTIVERECORD=3.0.0 | ||
| - rvm: 2.5.0 | ||
| env: ACTIVERECORD=3.1.0 | ||
| - rvm: 2.5.0 | ||
| env: ACTIVERECORD=3.2.0 | ||
| - rvm: 2.5.0 | ||
| env: ACTIVERECORD=4.0.0 | ||
| - rvm: 2.5.0 | ||
| env: ACTIVERECORD=4.1.0 | ||
| - rvm: rbx | ||
| env: ACTIVERECORD=5.0.0 | ||
| - rvm: rbx | ||
| env: ACTIVERECORD=5.1.1 | ||
| - 2.0 | ||
| - 2.1 | ||
| - 2.2 | ||
| - 2.3 | ||
| - 2.4 | ||
| - 2.5 | ||
| - 2.6 | ||
| - 2.7 | ||
| - 3.0 | ||
| - head | ||
| - rbx | ||
| gemfile: | ||
| - gemfiles/rails_3.0.gemfile | ||
| - gemfiles/rails_3.1.gemfile | ||
| - gemfiles/rails_3.2.gemfile | ||
| - gemfiles/rails_4.0.gemfile | ||
| - gemfiles/rails_4.1.gemfile | ||
| - gemfiles/rails_4.2.gemfile | ||
| - gemfiles/rails_5.0.gemfile | ||
| - gemfiles/rails_5.1.gemfile | ||
| - gemfiles/rails_5.2.gemfile | ||
| - gemfiles/rails_6.0.gemfile | ||
| - gemfiles/rails_6.1.gemfile | ||
| - gemfiles/rails_7_edge.gemfile | ||
| - gemfiles/datamapper.gemfile | ||
| - gemfiles/sequel.gemfile | ||
| jobs: | ||
| allow_failures: | ||
| - rvm: rbx | ||
| fast_finish: true | ||
| addons: | ||
| code_climate: | ||
| repo_token: a90435ed4954dd6e9f3697a20c5bc3754f67d94703f870e8fc7b00f69f5b2d06 | ||
| - rvm: head | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| - rvm: rbx | ||
| - gemfile: gemfiles/rails_4.2.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_4.2.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_4.2.gemfile | ||
| rvm: '2.2' | ||
| - gemfile: gemfiles/rails_4.2.gemfile | ||
| rvm: '2.3' | ||
| - gemfile: gemfiles/rails_4.2.gemfile | ||
| rvm: '2.4' | ||
| fast_finish: false | ||
| exclude: | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: '2.5' | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: '2.6' | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: '2.7' | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: '3.0' | ||
| - gemfile: gemfiles/rails_3.0.gemfile | ||
| rvm: head | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: '2.5' | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: '2.6' | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: '2.7' | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: '3.0' | ||
| - gemfile: gemfiles/rails_3.1.gemfile | ||
| rvm: head | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: '2.5' | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: '2.6' | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: '2.7' | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: '3.0' | ||
| - gemfile: gemfiles/rails_3.2.gemfile | ||
| rvm: head | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: '2.5' | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: '2.6' | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: '2.7' | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: '3.0' | ||
| - gemfile: gemfiles/rails_4.0.gemfile | ||
| rvm: head | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: '2.5' | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: '2.6' | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: '2.7' | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: '3.0' | ||
| - gemfile: gemfiles/rails_4.1.gemfile | ||
| rvm: head | ||
| - gemfile: gemfiles/rails_5.0.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_5.0.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_5.1.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_5.1.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_5.2.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_5.2.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_5.2.gemfile | ||
| rvm: '2.2' | ||
| - gemfile: gemfiles/rails_5.2.gemfile | ||
| rvm: '2.3' | ||
| - gemfile: gemfiles/rails_5.2.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_6.0.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_6.0.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_6.0.gemfile | ||
| rvm: '2.2' | ||
| - gemfile: gemfiles/rails_6.0.gemfile | ||
| rvm: '2.3' | ||
| - gemfile: gemfiles/rails_6.0.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_6.1.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_6.1.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_6.1.gemfile | ||
| rvm: '2.2' | ||
| - gemfile: gemfiles/rails_6.1.gemfile | ||
| rvm: '2.3' | ||
| - gemfile: gemfiles/rails_6.1.gemfile | ||
| rvm: '2.4' | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| rvm: '2.0' | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| rvm: '2.1' | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| rvm: '2.2' | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| rvm: '2.3' | ||
| - gemfile: gemfiles/rails_7_edge.gemfile | ||
| rvm: '2.4' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
|
|
||
| SUPPORTED_RAILS_VERSIONS = %w[3.0 3.1 3.2 4.0 4.1 4.2 5.0 5.1 5.2 6.0 6.1] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably a good time to trash everything below 5.2 |
||
|
|
||
| SUPPORTED_RAILS_VERSIONS.each do |rails_ver| | ||
| appraise "rails-#{rails_ver}" do | ||
| gem 'activerecord', "~> #{rails_ver}.x" | ||
| gem 'actionpack', "~> #{rails_ver}.x" | ||
|
|
||
| if %w[3.0 3.1 3.2].include?(rails_ver) | ||
| gem 'sqlite3' | ||
| #gem 'activerecord-sqlite3-adapter' | ||
| end | ||
|
|
||
| end | ||
| end | ||
|
|
||
| appraise 'rails-7-edge' do | ||
| gem 'activerecord', git: 'https://github.com/rails/rails', branch: 'main' | ||
| gem 'actionpack', git: 'https://github.com/rails/rails', branch: 'main' | ||
| end | ||
|
|
||
| appraise 'datamapper' do | ||
| gem 'datamapper' | ||
| gem 'dm-sqlite-adapter' | ||
| end | ||
|
|
||
| appraise 'sequel' do | ||
| gem 'sequel' | ||
| end | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| source 'https://rubygems.org' | ||
|
|
||
| gemspec | ||
|
|
||
| gem 'sqlite3' | ||
|
|
||
| if RUBY_VERSION < '2.1.0' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reallly ? |
||
| gem 'nokogiri' | ||
| gem 'public_suffix', '< 3.0.0' | ||
| end | ||
|
|
||
| platforms :jruby do | ||
| gem 'activerecord-jdbcsqlite3-adapter' | ||
| gem 'jdbc-sqlite3', '< 3.8.7' # 3.8.7 is nice and broke | ||
| end | ||
|
|
||
| group :development do | ||
| gem 'wwtd', require: false | ||
| gem 'rubocop', require: false | ||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not everybody uses Jetbrains editors.
While this does not hurt. its bad practice to clutter projects with local env settings.
best to put that in the home folder of the dev
my two cents on the topic