Lower noisy RangedAcknowledger log from WARN to DEBUG#263
Open
trex-amazon wants to merge 1 commit into
Open
Conversation
RangedAcknowledger.acknowledge() logs at WARN when a message is not found in the unacknowledged list (indexOf == -1). This is an expected, benign condition for already-acknowledged or already-deleted messages, and the code handles it gracefully by returning. Logging it at WARN floods logs with noise that operators routinely mistake for a real problem. Downgrade the message from WARN to DEBUG. No behavioral change; no public API change. The -1 case is still handled identically. Resolves awslabs#176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lowers a noisy log line from
WARNtoDEBUGinRangedAcknowledger.acknowledge().When the message being acknowledged isn't found in the unacknowledged list (
indexOf == -1) — an expected, benign condition for an already-acknowledged or already-deleted message — the code handles it gracefully by returning, but logs atWARN:At
WARNthis generates log noise that operators routinely mistake for a real fault.Change
Single-line change:
LOG.warn->LOG.debug. No behavioral change, no public API change. The-1case is still handled identically.Testing
mvn test -Dtest=RangedAcknowledgerTestpasses (4/4). No test asserts on the log level.Issues
Resolves #176