Skip to content

chore(tests): simplify universal tests#323

Merged
jackchuma merged 1 commit into
mainfrom
chore/simplify-universal-tests
Jun 2, 2026
Merged

chore(tests): simplify universal tests#323
jackchuma merged 1 commit into
mainfrom
chore/simplify-universal-tests

Conversation

@jackchuma
Copy link
Copy Markdown
Contributor

What changed? Why?

Simplifies the universal test suite by removing repeated setup, repeated assertions, and duplicate getter/interface coverage across the affected tests.

This keeps the same behavioral coverage while making the tests shorter and easier to review. The cleanup touches the universal test files for CrossDomainMessenger, multisig scripts, OptimismMintableERC20, Proxy, ProxyAdmin, ProxyAdminOwnedBase, StandardBridge, WETH98, and related helpers.

Notes to reviewers

  • This is test-only and does not change production contracts.
  • Proxy tests now deploy Proxy directly instead of going through DeployUtils.create1.
  • CrossDomainMessenger tests now use ForgeArtifacts.getSlot to look up the portal l2Sender storage slot instead of relying on a hardcoded slot index.
  • Several tests now share small helper functions for repeated minting, proxy admin calls, gas calculations, and message status assertions.

How has it been tested?

  • FOUNDRY_PROFILE=lite forge test --match-path 'test/universal/*.t.sol'

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jun 2, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma merged commit 0d93b4d into main Jun 2, 2026
6 checks passed
@jackchuma jackchuma deleted the chore/simplify-universal-tests branch June 2, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants