Skip to content

chore(tests): simplify util and vendor tests#324

Merged
jackchuma merged 2 commits into
mainfrom
chore/simplify-vendor-util-tests
Jun 2, 2026
Merged

chore(tests): simplify util and vendor tests#324
jackchuma merged 2 commits into
mainfrom
chore/simplify-vendor-util-tests

Conversation

@jackchuma
Copy link
Copy Markdown
Contributor

@jackchuma jackchuma commented Jun 2, 2026

What changed? Why?

Simplifies the utility and vendor test suites by reducing repeated test setup and reusing common calldata construction.

  • Adds helper constructors for repeated CBMulticall call payloads and makes delegatecall failures bubble the underlying revert data in the test helper.
  • Reuses initializer calldata across implementation/proxy pairs in Initializable.t.sol and removes the unused nickname indirection.
  • Updates the OpenZeppelin v5 initializer test to import the v5 Initializable type directly, reuse FeeVault constructor/init calldata, and assert the expected custom error selector.
  • Removes redundant test comments where the test name already captures the behavior.

Notes to reviewers

This is intended to be a test-only cleanup. The production contract surface is unchanged.

The CBMulticallDelegateCaller test helper now bubbles revert data so the non-allowed delegatecall failure test can assert the expected "Multicall3: call failed" revert instead of accepting any revert.

How has it been tested?

forge test --match-path test/utils/CBMulticall.t.sol

Result: 26 passed, 0 failed, 0 skipped.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jun 2, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma merged commit e225648 into main Jun 2, 2026
6 checks passed
@jackchuma jackchuma deleted the chore/simplify-vendor-util-tests branch June 2, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants