Merged
Conversation
jesperstarkar
approved these changes
Apr 9, 2026
Collaborator
jesperstarkar
left a comment
There was a problem hiding this comment.
Agree to the analysis of the root cause and the solution.
It now compiles and loads without error. I have done global searches and static analysis to look for imports not correctly updated, and not found any issues. All look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a:
Code improvement
Current Behavior
packages/corelib/src/dataModel/RundownPlaylist/index.tsexisted as a barrel file re-exporting symbols fromRundownPlaylist.tsandTTimers.ts, and other packages imported from.../dataModel/RundownPlaylist(implicitly via that barrel). Causing the webui to not load.New Behavior
The barrel file has been removed, and all imports have been updated to import directly from the concrete modules:
.../dataModel/RundownPlaylist/RundownPlaylist.../dataModel/RundownPlaylist/TTimersThis solves the webui issue.
Testing
Affected areas
Time Frame
Other Information
yarn test-allrun for the modified files; no linter errors introduced.@sofie-automation/corelib/dist/dataModel/RundownPlaylistis in commented-out code (SegmentNextPreview.tsx).Status