Skip to content

fix: webui imports#85

Merged
justandras merged 1 commit intorjmunro/t-timers-extrafrom
justandras/t-timers-extra-webui-fix
Apr 9, 2026
Merged

fix: webui imports#85
justandras merged 1 commit intorjmunro/t-timers-extrafrom
justandras/t-timers-extra-webui-fix

Conversation

@justandras
Copy link
Copy Markdown
Collaborator

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a:

Code improvement

Current Behavior

packages/corelib/src/dataModel/RundownPlaylist/index.ts existed as a barrel file re-exporting symbols from RundownPlaylist.ts and TTimers.ts, and other packages imported from .../dataModel/RundownPlaylist (implicitly via that barrel). Causing the webui to not load.

New Behavior

The barrel file has been removed, and all imports have been updated to import directly from the concrete modules:

  • .../dataModel/RundownPlaylist/RundownPlaylist
  • .../dataModel/RundownPlaylist/TTimers

This solves the webui issue.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

  • Type imports / module boundaries across packages.

Time Frame

  • This Bug Fix is critical for us, please review and merge it as soon as possible.

Other Information

  • Lint checked, yarn test-allrun for the modified files; no linter errors introduced.
  • One remaining reference to @sofie-automation/corelib/dist/dataModel/RundownPlaylist is in commented-out code (SegmentNextPreview.tsx).

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link
Copy Markdown
Collaborator

@jesperstarkar jesperstarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to the analysis of the root cause and the solution.

It now compiles and loads without error. I have done global searches and static analysis to look for imports not correctly updated, and not found any issues. All look good.

@justandras justandras merged commit 370d660 into rjmunro/t-timers-extra Apr 9, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants