Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
required: true
default: 'Benchmark'
tool:
description: 'Tool to use get benchmark output. One of "cargo", "go", "benchmarkjs", "pytest", "googlecpp", "catch2", "julia", "benchmarkdotnet", "customBiggerIsBetter", "customSmallerIsBetter"'
description: 'Tool to use get benchmark output. One of "cargo", "go", "benchmarkjs", "pytest", "googlecpp", "catch2", "julia", "benchmarkdotnet", "deno", "customBiggerIsBetter", "customSmallerIsBetter"'
required: true
output-file-path:
description: 'A path to file which contains the benchmark output'
Expand Down
1 change: 1 addition & 0 deletions src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const VALID_TOOLS = [
'julia',
'jmh',
'benchmarkdotnet',
'deno',
'customBiggerIsBetter',
'customSmallerIsBetter',
] as const;
Expand Down
76 changes: 76 additions & 0 deletions src/extract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,41 @@ export interface BenchmarkDotNetBenchmarkJson {
Benchmarks: BenchmarkDotnetBenchmark[];
}

export interface DenoBenchmarkResult {
ok?: {
n: number;
min: number;
max: number;
avg: number;
p75: number;
p95: number;
p99: number;
p995: number;
p999: number;
highPrecision: boolean;
usedExplicitTimers: boolean;
};
failed?: {
exceptionMessage: string;
};
}

export interface DenoBenchmark {
origin: string;
group?: string;
name: string;
baseline: boolean;
result?: DenoBenchmarkResult;
results?: DenoBenchmarkResult[];
}

export interface DenoBenchmarkJson {
version: number;
runtime: string;
cpu: string;
benches: DenoBenchmark[];
}

function getHumanReadableUnitValue(seconds: number): [number, string] {
if (seconds < 1.0e-6) {
return [seconds * 1e9, 'nsec'];
Expand Down Expand Up @@ -690,6 +725,44 @@ function extractLuauBenchmarkResult(output: string): BenchmarkResult[] {
return results;
}

function extractDenoBenchmarkResult(output: string): BenchmarkResult[] {
let json: DenoBenchmarkJson;
try {
json = JSON.parse(output);
} catch (err: any) {
throw new Error(
`Output file for 'benchmarkdotnet' must be JSON file generated by '--exporters json' option or by adding the JsonExporter to your run config: ${err.message}`,
);
}

if (json.version !== 1) {
throw new Error(`Unsupported version of deno benchmark output: ${json.version}`);
}

const results: BenchmarkResult[] = [];

for (const bench of json.benches) {
let result: DenoBenchmarkResult;
if (bench.result) {
result = bench.result;
} else if (bench.results && bench.results.length > 0) {
result = bench.results[0];
} else {
continue;
}
if (result.ok) {
results.push({
name: `${bench.origin}/${bench.group ?? '-'}/${bench.name}`,
value: result.ok.avg,
unit: 'ns',
extra: `n=${result.ok.n}`,
});
}
}

return results;
}

export async function extractResult(config: Config): Promise<Benchmark> {
const output = await fs.readFile(config.outputFilePath, 'utf8');
const { tool, githubToken, ref } = config;
Expand Down Expand Up @@ -732,6 +805,9 @@ export async function extractResult(config: Config): Promise<Benchmark> {
case 'benchmarkluau':
benches = extractLuauBenchmarkResult(output);
break;
case 'deno':
benches = extractDenoBenchmarkResult(output);
break;
default:
throw new Error(`FATAL: Unexpected tool: '${tool}'`);
}
Expand Down
2 changes: 2 additions & 0 deletions src/write.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ function biggerIsBetter(tool: ToolType): boolean {
return false;
case 'benchmarkdotnet':
return false;
case 'deno':
return false;
case 'customBiggerIsBetter':
return true;
case 'customSmallerIsBetter':
Expand Down
58 changes: 58 additions & 0 deletions test/__snapshots__/extract.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,64 @@ exports[`extractResult() extracts benchmark output from customSmallerIsBetter -
}
`;

exports[`extractResult() extracts benchmark output from deno - deno_output1.json 1`] = `
{
"benches": [
{
"extra": "n=49",
"name": "file:///dev/bench_me.js/-/Deno.UnsafePointerView#getUint32",
"unit": "ns",
"value": 1308.7523755102038,
},
],
"commit": {
"author": null,
"committer": null,
"id": "123456789abcdef",
"message": "this is dummy",
"timestamp": "dummy timestamp",
"url": "https://github.com/dummy/repo",
},
"date": 1712131503296,
"tool": "deno",
}
`;

exports[`extractResult() extracts benchmark output from deno - deno_output2.json 1`] = `
{
"benches": [
{
"extra": "n=5321",
"name": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts/Float32 writeAt/wgpu-memory",
"unit": "ns",
"value": 73232,
},
{
"extra": "n=6689",
"name": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts/Float32 writeAt/DataView",
"unit": "ns",
"value": 56036,
},
{
"extra": "n=8493",
"name": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts/Float32 writeAt/TypedArray",
"unit": "ns",
"value": 39802,
},
],
"commit": {
"author": null,
"committer": null,
"id": "123456789abcdef",
"message": "this is dummy",
"timestamp": "dummy timestamp",
"url": "https://github.com/dummy/repo",
},
"date": 1712131503296,
"tool": "deno",
}
`;

exports[`extractResult() extracts benchmark output from go - go_fiber_output.txt 1`] = `
{
"benches": [
Expand Down
25 changes: 25 additions & 0 deletions test/data/extract/deno_output1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"version": 1,
"runtime": "Deno/1.31.0 x86_64-apple-darwin",
"cpu": "Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz",
"benches": [
{
"origin": "file:///dev/bench_me.js",
"group": null,
"name": "Deno.UnsafePointerView#getUint32",
"baseline": false,
"result": {
"ok": {
"n": 49,
"min": 1251.9348,
"max": 1441.2696,
"avg": 1308.7523755102038,
"p75": 1324.1055,
"p99": 1441.2696,
"p995": 1441.2696,
"p999": 1441.2696
}
}
}
]
}
73 changes: 73 additions & 0 deletions test/data/extract/deno_output2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{
"version": 1,
"runtime": "Deno/2.1.4 aarch64-apple-darwin",
"cpu": "Apple M1 Max",
"benches": [
{
"origin": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts",
"group": "Float32 writeAt",
"name": "wgpu-memory",
"baseline": false,
"results": [
{
"ok": {
"n": 5321,
"min": 61917.0,
"max": 1205959.0,
"avg": 73232.0,
"p75": 64750.0,
"p99": 118500.0,
"p995": 122000.0,
"p999": 206583.0,
"highPrecision": true,
"usedExplicitTimers": true
}
}
]
},
{
"origin": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts",
"group": "Float32 writeAt",
"name": "DataView",
"baseline": false,
"results": [
{
"ok": {
"n": 6689,
"min": 54166.0,
"max": 602791.0,
"avg": 56036.0,
"p75": 54542.0,
"p99": 94000.0,
"p995": 94125.0,
"p999": 102250.0,
"highPrecision": true,
"usedExplicitTimers": true
}
}
]
},
{
"origin": "file:///Users/garciat/Desktop/wgpu-memory/benchmarks/scalar.bench.ts",
"group": "Float32 writeAt",
"name": "TypedArray",
"baseline": true,
"results": [
{
"ok": {
"n": 8493,
"min": 38667.0,
"max": 225917.0,
"avg": 39802.0,
"p75": 38958.0,
"p99": 59708.0,
"p995": 59958.0,
"p999": 133042.0,
"highPrecision": true,
"usedExplicitTimers": true
}
}
]
}
]
}
8 changes: 8 additions & 0 deletions test/extract.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,14 @@ describe('extractResult()', function () {
tool: 'benchmarkdotnet',
file: 'benchmarkdotnet.json',
},
{
tool: 'deno',
file: 'deno_output1.json',
},
{
tool: 'deno',
file: 'deno_output2.json',
},
{
tool: 'customBiggerIsBetter',
file: 'customBiggerIsBetter_output.json',
Expand Down