docs: suggest moving most PR checklist items to contributing guide#492
Open
noahjoeris wants to merge 1 commit into
Open
docs: suggest moving most PR checklist items to contributing guide#492noahjoeris wants to merge 1 commit into
noahjoeris wants to merge 1 commit into
Conversation
ValuedMammal
added
chore
ValuedMammal
reviewed
Jun 3, 2026
|
|
||
| - All commits are [GPG signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). | ||
| - The PR description links to the issue it solves, if one exists. | ||
| - `just pre-push` (alias `just p`) was run before pushing. |
Collaborator
There was a problem hiding this comment.
It'd be nice if this said what pre-push actually does - check that the code compiles, tests are passing, properly formatted and no clippy warnings.
Collaborator
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 80.93% 80.93%
=======================================
Files 24 24
Lines 5482 5482
Branches 247 247
=======================================
Hits 4437 4437
Misses 968 968
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggests moving most pull request checklist items from the PR template into
CONTRIBUTING.md, keeping checklist minimal.This follows the approach we added in
bdk-txrecently.Also fixes the contribution guidelines link in the PR template, which previously pointed at the bdk repo instead of this repo's CONTRIBUTING.md.
Notes to the reviewers
This is just a proposal, let me know if you like it.
Before submitting