Skip to content

Update synctools and stop subclassing AndroidEvent build+populate methods#782

Merged
sunkup merged 2 commits intomainfrom
781-dont-subclass-androidevent-androidcalendar-build-methods-anymore
Jan 13, 2026
Merged

Update synctools and stop subclassing AndroidEvent build+populate methods#782
sunkup merged 2 commits intomainfrom
781-dont-subclass-androidevent-androidcalendar-build-methods-anymore

Conversation

@sunkup
Copy link
Copy Markdown
Member

@sunkup sunkup commented Jan 13, 2026 •
edited
Loading

Purpose

Updating synctools step-by-step.

Short description

  • Update synctools version to bitfireAT/synctools@d10d516 (next intermediate step/commit of synctools rewrite)
  • Remove lastModified (now in AndroidEvent)
  • Remove uid (also in AndroidEvent)
  • Remove populate and build methods (logic now in AndroidEvent)
  • Adapt constructors to match

Note:
Please also review changes in bitfireAT/synctools#169

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup self-assigned this Jan 13, 2026
@sunkup sunkup added the refactoring Quality improvement of existing functions label Jan 13, 2026
@sunkup sunkup linked an issue Jan 13, 2026 that may be closed by this pull request
Don't subclass AndroidEvent build methods anymore #781
Closed
@sunkup sunkup changed the title Update synctools, remove lastModified and don't subclass AndroidEvent build+populate anymore Update synctools and don't subclass AndroidEvent build+populate anymore Jan 13, 2026
@sunkup sunkup changed the title Update synctools and don't subclass AndroidEvent build+populate anymore Update synctools and stop subclassing AndroidEvent build+populate Jan 13, 2026
@sunkup sunkup changed the title Update synctools and stop subclassing AndroidEvent build+populate Update synctools and stop subclassing AndroidEvent build+populate methods Jan 13, 2026
@sunkup sunkup requested a review from ArnyminerZ January 13, 2026 14:52
ArnyminerZ
ArnyminerZ approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ArnyminerZ ArnyminerZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough. It's always satisfying and scary to get so much code removed... 😅

Edit: reviewing now bitfireAT/synctools#169 Done ✅

@sunkup sunkup merged commit 917641b into main Jan 13, 2026
12 checks passed
@sunkup sunkup deleted the 781-dont-subclass-androidevent-androidcalendar-build-methods-anymore branch January 13, 2026 15:03
This was referenced Jan 19, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

Assignees

@sunkup sunkup

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't subclass AndroidEvent build methods anymore

2 participants

@sunkup @ArnyminerZ