Draft
Conversation
Add mem_allocator_malloc_aligned() API with support for both GC_VERIFY enabled and disabled modes. Related to DESIGN_ALIGNED_ALLOC.md
Add MEM_ALLOC_API_INTER macro for exposing internal functions in test builds and magic value constants for aligned allocation detection.
Convert obj_to_hmu to function that detects aligned allocations via magic value and calculates correct HMU offset.
Add CMocka support and mem-alloc test subdirectory.
Create basic test infrastructure with helper functions. Fix INTERP setting and add include directories for ems headers.
Verify existing mem_allocator_malloc still works correctly.
Add aligned allocation with over-allocation and metadata storage. Supports alignments from 8 bytes to page size. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify aligned allocations work for powers of 2. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
gc_realloc_vo now detects and rejects aligned allocations per POSIX behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify realloc correctly rejects aligned allocations and still works for normal allocations. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify invalid alignments and size requirements are enforced. Fix alignment validation to reject zero. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify normal and aligned allocations can coexist and obj_to_hmu works correctly for both. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Test many allocations and mixed allocation patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add public API for aligned memory allocation, exposing the existing mem_allocator_malloc_aligned infrastructure through wasm_export.h. - Add wasm_runtime_aligned_alloc() API declaration with documentation - Implement internal helper wasm_runtime_aligned_alloc_internal() - Add public function with size/alignment validation - POOL mode only, returns NULL for other memory modes - Follows wasm_runtime_malloc() patterns for consistency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive tests for the new public aligned allocation API: - Valid allocation in POOL mode with alignment verification - Zero size/alignment rejection - Non-POOL mode returns NULL - Realloc rejection for aligned allocations - Multiple alignment values (8, 16, 32, 64, 128, 256) Tests cover all scenarios from the implementation plan including error handling and mode-specific behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Simplify wasm_runtime_aligned_alloc_internal control flow using guard clause - Remove redundant wasm_runtime_init() calls in tests (wasm_runtime_full_init handles it) No functional changes, improves code readability and follows existing patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.