Core - Support building with VS 2026#5251
Conversation
📝 WalkthroughWalkthroughMSBuild props and the PowerShell build script were updated to target VS2022 by default and add conditional support for Visual Studio 2026 with the v145 platform toolset; obsolete VS2019 guidance was removed and build targets/toolchain mappings updated. ChangesVisual Studio 2026 Build Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Build CefSharp 147.0.100-CI5495 completed (commit 7497899a9e by @amaitland) |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
build.ps1 (1)
175-175:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix indentation to use spaces consistently.
Line 175 uses tab character(s) for indentation while the rest of the file uses spaces. PowerShell scripts should use consistent indentation.
🔧 Proposed fix
- $VS_PRE = "-prerelease"; + $VS_PRE = "-prerelease";🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@build.ps1` at line 175, The line setting $VS_PRE = "-prerelease" uses a tab for indentation while the rest of the script uses spaces; replace the leading tab characters before the assignment with the same number of spaces used elsewhere in the file (match the existing indentation style) so the $VS_PRE assignment uses consistent space-based indentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@build.ps1`:
- Line 175: The line setting $VS_PRE = "-prerelease" uses a tab for indentation
while the rest of the script uses spaces; replace the leading tab characters
before the assignment with the same number of spaces used elsewhere in the file
(match the existing indentation style) so the $VS_PRE assignment uses consistent
space-based indentation.
|
✅ Build CefSharp 148.0.90-CI5500 completed (commit d6ce2cb3ad by @amaitland) |
Allow building with VS 2026, currently lib cef wrapper isn't compiled with VS2026, so VS2026 will still use the older VS2022 compiled
.libfile.Part of #5243
Summary by CodeRabbit