Allow contributor resolution to identify github users from their noreply addresses#3786
Draft
Allow contributor resolution to identify github users from their noreply addresses#3786
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…are found Signed-off-by: Adrian Edwards <adredwar@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # to do this we should first do some sanity checks on the email | ||
| email_check = sanity_check_email(email) | ||
| if email_check is not None and 'users.noreply.github.com' in email_check: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
| # if we had a noreply address and there wasnt an issue parsing a numeric user ID, | ||
| # return now that we have the user record to validate that the profile we fetched for the username | ||
| # does indeed match the correct user | ||
| if email_check is not None and 'users.noreply.github.com' in email_check and user_id is not None: |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR shows what an implementation might look like if we wanted to account for github noreply user emails in the contributor resolution process since this specific email format makes it easier to connect a user to their commits with fewer API calls.
This PR fixes #3784
Notes for Reviewers
Not yet tested, can do so if this is a desireable change
Signed commits