Skip to content

Substring pattern match #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chdsbd wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Substring pattern match #32

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cfe3a3
Substring pattern match
chdsbd Mar 14, 2026
0e53758
version
chdsbd Mar 14, 2026
0b5826b
add more information to hover
chdsbd Mar 14, 2026
6e675c0
dead code
chdsbd Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## 4.2.0 - 2026-03-14

### Changed

- Adjust hover text for substring vs full path matches (#).

## 4.1.0 - 2024-04-13

### Changed
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Quickly see GitHub Code Owners for the current file. Add syntax highlighting for CODEOWNERS files.",
"publisher": "chdsbd",
"license": "SEE LICENSE IN LICENSE",
"version": "4.1.0",
"version": "4.2.0",
"icon": "images/logo256.png",
"homepage": "https://github.com/chdsbd/vscode-github-code-owners/blob/master/README.md",
"keywords": [
Expand Down
6 changes: 1 addition & 5 deletions src/codeowners-hover-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

let isDirectory: boolean | null = null
try {
isDirectory = fs.statSync(myPath).isDirectory()

Check failure on line 22 in src/codeowners-hover-provider.ts

View workflow job for this annotation

GitHub Actions / lint 

'isDirectory' is assigned a value but never used
} catch (e) {
// @ts-expect-error we should see this error.
if (e.code !== "ENOENT") {
Expand All @@ -42,11 +42,7 @@
range,
contents: [
x,
isPattern
? "Matches all files with same name"
: isDirectory
? `Matches all files in directory and subdirectories`
: `Matches path exactly`,
isPattern ? "Substring pattern match" : `Matches path exactly`,
],
}
}
Expand Down
Loading