Skip to content

Revert "Revert "More module refactoring""#607

Merged
selzoc merged 1 commit into
ubuntu-jammyfrom
revert-606-revert-595-more-module-refactoring
Jun 2, 2026
Merged

Revert "Revert "More module refactoring""#607
selzoc merged 1 commit into
ubuntu-jammyfrom
revert-606-revert-595-more-module-refactoring

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented Jun 2, 2026

Reverts #606 (The USN https://ubuntu.com/security/notices/USN-8373-1 did not patch the 5.15 kernel!!!)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 99027ce3-0685-47d3-9b75-82577521523f

📥 Commits

Reviewing files that changed from the base of the PR and between 363c99f and 9eaf14a.

📒 Files selected for processing (2)
  • bosh-stemcell/spec/support/os_image_linux_kernel_modules_shared_examples.rb
  • stemcell_builder/stages/system_kernel_modules/apply.sh

Walkthrough

This PR extends the kernel module blacklist configuration by adding three additional network-related modules: esp4, esp6, and rxrpc. The implementation modifies the system kernel modules setup script to install these modules to /bin/true, preventing them from loading. The change is accompanied by new RSpec test contexts that verify the blacklist file contains the correct entries for each module.

Suggested reviewers

  • rkoster
  • beyhan
  • aramprice
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required information per template: it does not specify the target branch strategy (Merge Forward), acknowledge the merge forward process, or indicate which subsequent branches need merges. Add information about following the Merge Forward strategy and specify which branches (merge-to-<next_short_name>) should receive this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the PR's primary change: reverting a previous revert to restore module refactoring, which matches the changeset's addition of kernel module blacklist rules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-606-revert-595-more-module-refactoring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@selzoc selzoc merged commit 5ab49f3 into ubuntu-jammy Jun 2, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants