Replacing validate uniqueness with db constraint on Buildpack model#4942
Merged
philippthun merged 6 commits intocloudfoundry:mainfrom Mar 24, 2026
Conversation
serdarozerr
changed the title
philippthun
reviewed
Mar 24, 2026
philippthun
approved these changes
Mar 24, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 24, 2026
Changes in cloud_controller_ng:
- Replacing validate uniqueness with db constraint on Buildpack model
PR: cloudfoundry/cloud_controller_ng#4942
Author: serdar özer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Sequel
validates_uniquecheck with a DB-level unique index on(name, stack, lifecycle). Thearound_savehook catchesUniqueConstraintViolationand converts it toValidationFailed, making uniqueness enforcement race-condition safe.Changes
unique_name_and_stackindex, adds newbuildpacks_name_stack_lifecycle_index(idempotent)validates_unique, addedaround_savefor DB-level enforcementI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests