Skip to content

Rename integration_test_properties to mockmvc_unittest_properties#3914

Merged
duanemay merged 2 commits into
developfrom
mockmvc_unittest_props
May 18, 2026
Merged

Rename integration_test_properties to mockmvc_unittest_properties#3914
duanemay merged 2 commits into
developfrom
mockmvc_unittest_props

Conversation

@duanemay
Copy link
Copy Markdown
Member

The file name integration_test_properties.yml was confusing since it was only used during some unit tests, mostly mockmvc (via @DefaultTestContext) and:

  • TestZonifyGroupSchema_V2_4_1 - Database schema/migration test
  • UaaBootServerCustomizerTest - Boot server configuration test
  • SmtpConfigurationTest - SMTP configuration test (uses nested @DefaultTestContext)
  • YamlConfigurationValidationTests - YAML validation test (sets UAA_CONFIG_URL directly)

The file name integration_test_properties.yml was confusing since it was only used during some unit tests, mostly mockmvc (via @DefaultTestContext) and:

- TestZonifyGroupSchema_V2_4_1 - Database schema/migration test
- UaaBootServerCustomizerTest - Boot server configuration test
- SmtpConfigurationTest - SMTP configuration test (uses nested @DefaultTestContext)
- YamlConfigurationValidationTests - YAML validation test (sets UAA_CONFIG_URL directly)
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the test-only UAA YAML configuration file to better reflect its primary usage by MockMvc-focused unit/component tests (e.g., via @DefaultTestContext), and updates references/documentation accordingly.

Changes:

  • Add uaa/src/test/resources/mockmvc_unittest_properties.yml as the new canonical test config YAML.
  • Update tests/initializers to point UAA_CONFIG_URL at the renamed YAML.
  • Update zone-path feature documentation to reference the new file name.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
uaa/src/test/resources/mockmvc_unittest_properties.yml Provides the renamed YAML configuration used by MockMvc/unit-style tests.
uaa/src/test/java/org/cloudfoundry/identity/uaa/YamlConfigurationValidationTests.java Updates UAA_CONFIG_URL to load the renamed YAML in validation tests.
uaa/src/test/java/org/cloudfoundry/identity/uaa/DefaultTestContext.java Updates the UAA_CONFIG_URL initializer to use the renamed YAML for @DefaultTestContext.
docs/zone-path-feature.md Replaces references to the old YAML name with the new one in zone-path documentation.

Comment thread docs/zone-path-feature.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group May 18, 2026
@duanemay duanemay merged commit 069b448 into develop May 18, 2026
27 checks passed
@duanemay duanemay deleted the mockmvc_unittest_props branch May 18, 2026 15:24
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants