Skip to content

fix(create-cli): add missing jsdocs-plugin dependency#1280

Merged
hanna-skryl merged 1 commit intomainfrom
create-cli-jsdocs-dependency
Mar 31, 2026
Merged

fix(create-cli): add missing jsdocs-plugin dependency#1280
hanna-skryl merged 1 commit intomainfrom
create-cli-jsdocs-dependency

Conversation

@hanna-skryl
Copy link
Copy Markdown
Collaborator

The jsdocs-plugin import was added to create-cli in #1279 but the package was not added to dependencies in package.json. This causes ERR_MODULE_NOT_FOUND when running npm init @code-pushup/create-cli from a published install.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 30, 2026

View your CI Pipeline Execution ↗ for commit 0fb7a53

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 31s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 55s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 2m 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-30 18:57:47 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 30, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1280

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1280

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1280

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1280

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1280

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1280

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1280

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1280

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1280

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1280

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1280

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1280

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1280

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1280

commit: 0fb7a53

@hanna-skryl hanna-skryl marked this pull request as ready for review March 30, 2026 18:51
@github-actions
Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 22a7952 with previous commit 1ab9f27.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 36 ↓ −0.5
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Code coverage 🟢 92 🟢 92
Security 🔴 0 🔴 0
Updates 🟡 73 🟡 73
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Documentation 🟡 51 🟡 51
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 1 group regressed, 👍 2 audits improved, 👎 2 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 36 ↓ −0.5

33 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.7 s 🟥 6.4 s ↑ +11.9 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.0 s ↓ −2.7 %
Lighthouse Total Blocking Time 🟥 2,200 ms 🟥 2,030 ms ↓ −7.8 %
Lighthouse Time to Interactive 🟥 14.2 s 🟥 14.6 s ↑ +2.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,445 KiB 🟩 Total size was 2,447 KiB ↑ +0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.6 %
Lighthouse Server Backend Latencies 🟩 640 ms 🟩 960 ms ↑ +50.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 297 KiB 🟥 Potential savings of 321 KiB ↓ −19.3 %
Lighthouse JavaScript execution time 🟥 3.0 s 🟥 2.8 s ↓ −6.5 %
Lighthouse Minimizes main-thread work 🟥 11.4 s 🟥 11.2 s ↓ −1.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 78 KiB 🟥 Potential savings of 78 KiB ↑ +50 %
Lighthouse Initial server response time was short 🟩 Root document took 450 ms 🟩 Root document took 570 ms ↑ +25.8 %
Lighthouse Max Potential First Input Delay 🟥 1,290 ms 🟥 1,370 ms ↑ +5.6 %
Lighthouse Largest Contentful Paint 🟥 13.3 s 🟥 13.3 s ↑ +0.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 102 KiB 🟥 Potential savings of 95 KiB ↓ −2.2 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↑ +8.8 %

661 other audits are unchanged.

@github-actions
Copy link
Copy Markdown
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared current commit 22a7952 with previous commit 1ab9f27.

💼 Project plugin-coverage

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 68 🟡 68 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 68 🟡 68 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.


13 other projects are unchanged.

@hanna-skryl hanna-skryl requested a review from matejchalk March 30, 2026 18:58
@hanna-skryl hanna-skryl merged commit 705e777 into main Mar 31, 2026
25 checks passed
@hanna-skryl hanna-skryl deleted the create-cli-jsdocs-dependency branch March 31, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants