refactor: remove PHPStan callable signature baseline#10166
Open
memleakd wants to merge 2 commits intocodeigniter4:developfrom
Open
refactor: remove PHPStan callable signature baseline#10166memleakd wants to merge 2 commits intocodeigniter4:developfrom
memleakd wants to merge 2 commits intocodeigniter4:developfrom
Conversation
memleakd
force-pushed
the
refactor/phpstan-callable-types
branch
from
7740173 to
c1658d6
Compare
patel-vansh
approved these changes
May 8, 2026
paulbalandan
reviewed
May 9, 2026
paulbalandan
approved these changes
May 9, 2026
Member
|
This needs rebasing too but wait until the other cleanup is merged to reduce duplicate effort. Thanks! |
|
👋 Hi, @memleakd! |
Member
|
Please rebase now. |
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
memleakd
force-pushed
the
refactor/phpstan-callable-types
branch
from
1a19a03 to
b1d993b
Compare
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds PHPDoc callable signatures where PHPStan reported missing callable parameter/return signatures.
This removes all entries from
missingType.callable.neon, deletes the now-empty baseline file, and removes its loader include. It also removes one relatedassign.propertyTypebaseline entry forTable::$function, since the property PHPDoc now supports the invalid callback string tested inTableTest.Related to #6310.
Verification:
composer phpstan:checkgit diff --checkChecklist: