🤖 feat: preview markdown attach_file outputs#3318
Merged
Merged
Conversation
Show markdown files attached through attach_file as display-only previews with download affordances, keeping their bytes out of model attachments. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$10.87`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=10.87 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds display-only markdown support to
attach_file, so generated.mdfiles can be previewed and downloaded in chat without being sent back to the model as file attachments.Background
Agents can already use file read tools when they need markdown contents. This keeps that boundary intact while making agent-generated markdown files easy for users to inspect and save.
Implementation
.md,.markdown,.mdown, and explicittext/markdownoverrides as display-only attach_file outputs.Validation
bun test src/node/services/tools/attach_file.test.ts src/browser/features/Tools/AttachFileToolCall.test.tsxmake static-checkagent-browser: openedapp-chat-tools-attachfile--display-only-markdown, verified the markdown preview and Download link, and captured screenshot/video evidence in chat.Risks
Low. The new path reuses the existing display-only file mechanism, so markdown bytes are stripped from provider requests like other display-only files. Non-markdown text-like files still fail and direct the agent toward file_read.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$10.87