🤖 fix: silence goal continuation skip log spam during streams#3325
Open
ammar-agent wants to merge 1 commit into
Open
🤖 fix: silence goal continuation skip log spam during streams#3325ammar-agent wants to merge 1 commit into
ammar-agent wants to merge 1 commit into
Conversation
The goal continuation idle consumer self-reschedules ~1s while a stream is active (eligibility returns currently_streaming/initializing with deferUntilMs). Logging at info on every retry produced one line per second for the entire stream duration. Demote to debug for the self-deferring reasons; terminal reasons keep info.
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demote the
WorkspaceGoalService: skipped goal continuationlog todebugwhen eligibility is self-deferring, so we no longer spam one info line per second for the entire duration of every active stream.Background
WorkspaceGoalService.buildGoalContinuationPayloadruns whenever the idle dispatcher invokes the goal continuation consumer. For transient reasons (currently_streaming,initializing),checkGoalContinuationEligibilityreturnsdeferUntilMs = nowMs + 1_000andscheduleContinuationReRequestre-arms a dispatch one second later. That self-rescheduling loop produced aninfo-level log every ~1s for the entire duration of a stream:Implementation
In
buildGoalContinuationPayload, route the skip log throughlog.debugwheneligibility.deferUntilMs != null(the self-retrying transient states) and keeplog.infofor terminal reasons (goal_mismatch,user_stop,plan_mode,archived, …) that fire at most once and remain useful diagnostic signal. A short comment near the log explains the policy so future edits don't accidentally re-promote these reasons.Risks
Very low. Only changes log verbosity on one site; no eligibility logic, dispatch behavior, or persisted state is affected. Debug entries still surface when
MUX_DEBUG=1/MUX_LOG_LEVEL=debugor when an Output tab subscriber requests them, so on-demand diagnosis is preserved.Validation
make static-check— cleanbun test src/node/services/workspaceGoalService.test.ts— 117/117 pass (no test asserted on this log line)Generated with
mux• Model:anthropic:claude-opus-4-7• Thinking:max• Cost:$0.94